Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help maintaining this Package #41

Open
NHDaly opened this issue Nov 23, 2019 · 10 comments
Open

Help maintaining this Package #41

NHDaly opened this issue Nov 23, 2019 · 10 comments

Comments

@NHDaly
Copy link
Owner

NHDaly commented Nov 23, 2019

Hi friends! :)

Unfortunately, I haven't had the time to maintain this package of late. I haven't been keeping up to date with the latest tmux in a long time. My setup mostly works, and I haven't been spending much time tweaking it anymore.

Would any of you active users be interested in joining maintenance of this package? If so, please let me know, either via an email or a comment here! Thanks!

@NHDaly
Copy link
Owner Author

NHDaly commented Nov 23, 2019

CC: @iamjamestl and @giddie, you have both done great development work on this package. Would you be interested in joining as a Maintainer / Collaborator? Thanks for all your help so far! :)

@unphased
Copy link

unphased commented Nov 26, 2019

I'd like to contribute but I'm not up to speed on this codebase yet.

What I can report is that for tmux, somewhere between the tmux 3.0 tag (commit c7397724) and master the functionality of set -g @scroll-without-changing-pane "on" breaks for me. It does appear that the other configurations that I set are continuing to work.

@unphased
Copy link

@scroll-speed-num-lines-per-scroll seems to only affect alternate buffer emulated scrolling speed, and does not affect copy mode/history scroll speed. (Readme is not clear on whether this is a bug or not)

@giddie
Copy link
Contributor

giddie commented Dec 3, 2019

Sorry, it looks like I haven't used this plugin since upgrading to tmux 3.0_a. I remember that they changed some stuff with the way the mouse works, and as a result it's been working fine for me for a while now without this plugin.

I'd be very interested in knowing what usecases might still be broken for others, though?

@NHDaly
Copy link
Owner Author

NHDaly commented Dec 10, 2019

Haha oh good, well i'm glad to hear that then! I've just kept it installed, but i don't know where it helps and where it doesn't.

As @unphased pointed out, I don't think @scroll-speed-num-lines-per-scroll works anymore. And I've noticed scrolling doesn't work in git log anymore, where I think it used to? But yeah i'm not too sure either. I just know that there are several open issues that I haven't responded to:

@giddie
Copy link
Contributor

giddie commented Dec 12, 2019

As @unphased pointed out, I don't think @scroll-speed-num-lines-per-scroll works anymore. And I've noticed scrolling doesn't work in git log anymore, where I think it used to? But yeah i'm not too sure either. I just know that there are several open issues that I haven't responded to:

So git log scrolling works just fine for me currently with tmux 3.0_a without this plugin. I do use the tmux-scroll-copy-mode plugin with @prevent-scroll-for-fullscreen-alternate-buffer on, but I think that's probably not relevant.

@NHDaly
Copy link
Owner Author

NHDaly commented Dec 19, 2019

huh, good to know. Maybe this package can just be parked if it's not really needed on 3.0 anymore? That would be great! This only existed as a stopgap while waiting for better mouse support in tmux itself anyway

@xiruizhao
Copy link

Tested on macOS Catalina 10.15.3 with tmux 3.0a. scroll-without-changing-pane, scroll-speed-num-lines-per-scroll, and emulate-scroll-for-no-mouse-alternate-buffer work. git log scrolling does not work without this plugin.

@giddie
Copy link
Contributor

giddie commented Mar 24, 2020

That's interesting. I use Konsole; maybe the terminal emulator itself makes a difference here?

@unphased
Copy link

unphased commented Mar 24, 2020

More often than not, git log is displayed in less; many terminals do emulate keypad controls based on mouse scroll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants