Skip to content

Take PLR into account in the calculation of leaving water temperature of Coil:Heating:Water for cycling operations #11060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
lymereJ wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Take PLR into account in the calculation of leaving water temperature of Coil:Heating:Water for cycling operations #11060

lymereJ wants to merge 11 commits into from
+301 −1

Conversation

@lymereJ
Copy link
Collaborator

@lymereJ lymereJ commented May 16, 2025

Pull request overview

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@lymereJ lymereJ added the Defect Includes code to repair a defect in EnergyPlus label May 16, 2025
@github-actions
Copy link

github-actions bot commented May 16, 2025

⚠️ Regressions detected on macos-14 for commit 3e29664

Regression Summary
  • ESO Big Diffs: 6
  • MTR Big Diffs: 6
  • Table Big Diffs: 9
  • ESO Small Diffs: 2
  • MTR Small Diffs: 1
  • Table String Diffs: 8
  • EIO: 4
  • ERR: 1

@github-actions
Copy link

github-actions bot commented May 17, 2025

⚠️ Regressions detected on macos-14 for commit 9d96c52

Regression Summary
  • ESO Big Diffs: 4
  • MTR Big Diffs: 6
  • Table Big Diffs: 9
  • ESO Small Diffs: 7
  • MTR Small Diffs: 3
  • Table String Diffs: 6
  • EIO: 3
  • Table Small Diffs: 1
  • ERR: 1

@github-actions
Copy link

github-actions bot commented May 17, 2025

⚠️ Regressions detected on macos-14 for commit ddbb87c

Regression Summary
  • ESO Big Diffs: 4
  • MTR Big Diffs: 6
  • Table Big Diffs: 9
  • ESO Small Diffs: 7
  • MTR Small Diffs: 3
  • Table String Diffs: 6
  • EIO: 3
  • Table Small Diffs: 1
  • ERR: 1

@lymereJ lymereJ added this to the EnergyPlus 25.2 IO Freeze milestone May 19, 2025
@lymereJ lymereJ closed this May 20, 2025
@lymereJ lymereJ reopened this May 26, 2025
@github-actions
Copy link

github-actions bot commented May 26, 2025

⚠️ Regressions detected on macos-14 for commit e4f5d5a

Regression Summary
  • Table Big Diffs: 11
  • ESO Big Diffs: 3
  • MTR Big Diffs: 5
  • ESO Small Diffs: 5
  • MTR Small Diffs: 2
  • Table String Diffs: 6
  • EIO: 2

@github-actions
Copy link

github-actions bot commented May 26, 2025

⚠️ Regressions detected on macos-14 for commit e4f5d5a

Regression Summary
  • Table Big Diffs: 11
  • ESO Big Diffs: 3
  • MTR Big Diffs: 5
  • ESO Small Diffs: 5
  • MTR Small Diffs: 2
  • Table String Diffs: 6
  • EIO: 2

@Myoldmopar
Copy link
Member

Myoldmopar commented Jun 13, 2025

(@lymereJ my apologies, I pushed a commit to test something out on a branch that causes diffs. If it's acting funny at all, I'll revert it back out in the morning.)

@github-actions
Copy link

github-actions bot commented Jun 13, 2025

⚠️ Regressions detected on macos-14 for commit 46f70d9

Regression Summary
  • ESO Big Diffs: 3
  • MTR Big Diffs: 5
  • Table Big Diffs: 8
  • ESO Small Diffs: 5
  • MTR Small Diffs: 2
  • Table String Diffs: 6
  • EIO: 2

@github-actions
Copy link

github-actions bot commented Jun 13, 2025

⚠️ Regressions detected on macos-14 for commit e4f90c9

Regression Summary
  • ESO Big Diffs: 3
  • MTR Big Diffs: 5
  • Table Big Diffs: 8
  • ESO Small Diffs: 5
  • MTR Small Diffs: 2
  • Table String Diffs: 6
  • EIO: 2

@nrel-bot-2
Copy link

nrel-bot-2 commented Jul 13, 2025

@lymereJ @Myoldmopar it has been 29 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Aug 22, 2025

@lymereJ @Myoldmopar it has been 40 days since this pull request was last updated.

@nrel-bot-2
Copy link

nrel-bot-2 commented Sep 24, 2025

@lymereJ @Myoldmopar it has been 33 days since this pull request was last updated.

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit c3e5ec9

Regression Summary
  • ESO Big Diffs: 3
  • MTR Big Diffs: 5
  • Table Big Diffs: 8
  • Table String Diffs: 7
  • ESO Small Diffs: 5
  • MTR Small Diffs: 2
  • EIO: 2

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

⚠️ Regressions detected on macos-14 for commit c3e5ec9

Regression Summary
  • ESO Small Diffs: 5
  • MTR Small Diffs: 2
  • Table Big Diffs: 8
  • Table String Diffs: 6
  • ESO Big Diffs: 3
  • MTR Big Diffs: 5
  • EIO: 2

@mitchute
Copy link
Collaborator

mitchute commented Oct 22, 2025

@lymereJ Is this ready for a closer look?

@lymereJ
Copy link
Collaborator Author

lymereJ commented Oct 22, 2025 •
edited
Loading

@mitchute - Short answer, no, It's not complete. I'm not sure if I'll have time to get to it before the upcoming release. If we could keep it open, that would be great.

There's another piece to it that I have not pushed yet (I might create a different issue/PR for it) and I'm not sure that I like the proposed changes even though it addresses the issue.

@mitchute mitchute removed this from the EnergyPlus 25.2 milestone Oct 22, 2025
@nrel-bot-2
Copy link

nrel-bot-2 commented Nov 20, 2025

@lymereJ @Myoldmopar it has been 28 days since this pull request was last updated.

rraustad
rraustad reviewed Nov 21, 2025
View reviewed changes
src/EnergyPlus/WaterCoils.cc
if (CapacitanceWater > 0 &&
state.dataPlnt->PlantLoop(waterCoil.WaterPlantLoc.loopNum).LoopSide(DataPlant::LoopSideLocation::Supply).FlowRequest > 0) {
TempWaterOut = TempWaterIn - HeatingCoilLoad / CapacitanceWater;
}
Copy link
Contributor

@rraustad rraustad Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hurting my brain a little bit. The concept of cycling fan is that the outlet condition will be full output and the mass flow rate will be averaged based on PLR. For constant fan mass flow is full flow and outlet conditions are averaged. In both cases energy is conserved. So the question is whether air and water mass flow rate is averaged here for cycling fan. At line 2837 and 2838 you see that the air and water flow rate is bumped up to full flow, for LOCAL variables, but the node data still holds the averaged values. So to also average the water outlet temp means that the impact of PLR is applied twice. Why wasn't this also done for outlet air temperature? I think a simple check of air-side energy versus water side energy will show the correct values (i.e., either this was correct before or it's correct now). I think this change breaks the energy conservation rule. Think about line 2905, it's averaging the coil output because it's cycling fan, and HeatingCoilLoad was calculated at full capacity ... using LOCAL adjusted variables for air and water mass flow rate. The outlet water temp, and air temp, in this case should be full capacity output. Also, what the heck does plant FlowRequest have to do with this calculation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rraustad rraustad rraustad left review comments

Assignees

No one assigned

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Energy imbalance in plant loop when changing component Flow Mode

8 participants

@lymereJ @Myoldmopar @nrel-bot-2 @mitchute @rraustad @nrel-bot-2c @mjwitte