Fix #11267 - Ensure consistency of IDF file formats for easier diffing #11268
+79,382
−49,755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gured from an in.f90 file
``` git diff -U0 | grepdiff 'Watts per Zone' --output-matching=hunk | git apply --cached --unidiff-zero git diff -U0 | grepdiff 'Rate per Exterior' --output-matching=hunk | git apply --cached --unidiff-zero ``` more ``` git diff -U0 | grepdiff 'Zone Load Sizing Method' --output-matching=hunk | git apply --cached --unidiff-zero git diff -U0 | grepdiff 'Coefficient1 Constant' --output-matching=hunk | git apply --cached --unidiff-zero [etc] ``` Then I manually added the rest of the formatting changes
…ableSpeed and WaterToAir[chore] HeatPump and AirToWaterHeatPump and PCM coils
```
{'Coil:Cooling:DX:VariableSpeed',
'Coil:Cooling:WaterToAirHeatPump:EquationFit',
'Coil:Cooling:WaterToAirHeatPump:ParameterEstimation',
'Coil:Cooling:WaterToAirHeatPump:VariableSpeedEquationFit',
'Coil:Heating:DX:VariableSpeed',
'Coil:Heating:WaterToAirHeatPump:EquationFit',
'Coil:Heating:WaterToAirHeatPump:ParameterEstimation',
'Coil:Heating:WaterToAirHeatPump:VariableSpeedEquationFit',
'Coil:WaterHeating:AirToWaterHeatPump:Pumped',
'Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed',
'Coil:WaterHeating:AirToWaterHeatPump:Wrapped',
'ThermalStorage:HotWater:Stratified'}
```
jmarrec
added
Defect
…lExecutor (this is too slow for pratical use: takes 1 to 2 hr to reformat testfiles/)
jmarrec
force-pushed
the
11267_format_idfs
branch
from
d5d328c to
21cb6d3
Compare
|
|
mitchute
reviewed
Oct 10, 2025
Comment on lines
-393
to
+392
| 934.4, !- 2023 Rated Evaporator Fan Power Per Volume Flow {W/(m3/s)} | ||
| , !- 2017 Rated Evaporator Fan Power Per Volume Flow Rate {W/(m3/s)} |
There was a problem hiding this comment.
This change seems like a regression. I'm not arguing with what is in the schema, just noting it.
There was a problem hiding this comment.
I guess we would just run this on our own occasionally, or it is going to be part of a more formal check? Would it be fast enough to run as part of our ./scripts/dev/apply_formatting.sh cleanup?
Comment on lines
-18
to
-20
| ! Version, | ||
| ! 9.0; !- Version Identifier | ||
|
|
There was a problem hiding this comment.
I'm debating whether it would be useful to keep the version identifiers here and in other files that are just IDF object holders, and not really simulation input files.
There was a problem hiding this comment.
If the version object and number was in those files, wouldn't the transition program work on them?
|
Now the next can of 🪱 🪱 🪱 ... what about the IDF objects in the unit tests and docs?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Description of the purpose of this PR
In particular I had about 50 files failures, and after a lot of effort I isolated the issue: the tool removed some coils
Pull Request Author
Reviewer