Ssc 195 day of week improvements #2109
Conversation
…pdate defaults accordingly
brtietz
added
enhancement
financial
Ah, thanks for the reminder! Just pushed them. |
* Change label from "Jan 1st Day of Week" to "January 1 day of week". * Add tooltip on Electric Load page for consistency with other inputs. * Add UI message for TPO Host / Developer so users know Electric Load page and TOD Factors page inputs are linked.
…y_of_week_improvements
…/NREL/SAM into ssc_195_day_of_week_improvements
There was a problem hiding this comment.
@brtietz Thank you for adding start day of year to BELPE UI form.
Note for documentation that BELPE does not calculate different loads for weekdays and weekends, so this input has no impact on the load data itself.
I tested this a bit and for the default residential case there are slight differences: 
Start on Monday: Start on Saturday: Note where the 1.8 kW peaks land (weekdays appear to peak at 1.7). So not a huge difference (I have to lean in and squint), but this input does affect the BELPE results. |
…/NREL/SAM into ssc_195_day_of_week_improvements
|
@cpaulgilman Just flagging that I forgot to push the ssc changes until just now, so you wouldn't have seen any changes when you tested this morning. Doh! |
Good to know that BELPE bumps up the load slightly on weekend days. |
…y_of_week_improvements
|
Fixing an extra space between "January" and "1" on the input page label for the Electric load page, otherwise looks good with my testing! |
…y_of_week_improvements
… pvwatts changes from a previous PR as well
4 participants
Pull Request Template
Description
Add UI functionality for day of week behavior. This was implemented one of three places:
The host developer model has the pages for both (1) and (2) so that required the implementation of UI variables. The core SSC variable is on the financial analysis page so that the compute modules have access to it. Open to ideas on a cleaner approach here.
The LCOE models and No financial configurations use the ?=0 in the vartable and continue to default to Monday (maintaning the previous behavior). We can open this up if users ask.
Fixes NREL/ssc#195
Corresponding branches and PRs:
Develop for lk and wex
Corresponding ssc PR NREL/ssc#1352
Unit Test Impact:
No expected changes to SAM tests.
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)