-
Notifications
You must be signed in to change notification settings - Fork 195
Update sco2 python functionality for new configurations #2118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
TODO: Update documentation https://github.com/NREL/SAM/blob/develop/samples/CSP/sco2_analysis_python_V2/example/User_Guide.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates sco2 python functionality to support two new cycle configurations - recompression with HTR bypass (configuration 3) and turbine split flow (configuration 4).
- Adds design parameters for HTR bypass and turbine split flow configurations
- Updates plotting functionality to handle visualization of the new cycle configurations
- Refactors code to use configurable flags for saving outputs
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
design_point_examples.py | Adds new configuration parameters and implements configurable output saving |
sco2_plots.py | Updates cycle plotting logic to support HTR BP and TSF configurations with proper state point mappings |
sco2_cycle_ssc.py | Adds default parameters and cycle name handling for the new configurations |
Comments suppressed due to low confidence (1)
samples/CSP/sco2_analysis_python_V2/core/sco2_plots.py:1
- Corrected spelling of 'paramters' to 'parameters'.
# -*- coding: utf-8 -*-
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description
Update sco2 python examples and support functions to include new configurations - recompression with htr bypass and turbine split flow.
Corresponding branches and PRs:
wex, lk: develop
ssc: sco2_tsf
Linked to PR https://github.com/NREL/ssc/pull/1353
Unit Test Impact:
No change to unit tests; however there are new unit tests in ssc for the new sco2 configurations.
Checklist