Update sco2 python functionality for new configurations#2118
Merged
taylorbrown75 merged 17 commits intodevelopfrom Oct 22, 2025
Merged
Update sco2 python functionality for new configurations#2118taylorbrown75 merged 17 commits intodevelopfrom
taylorbrown75 merged 17 commits intodevelopfrom
Conversation
Collaborator
Author
|
TODO: Update documentation https://github.com/NREL/SAM/blob/develop/samples/CSP/sco2_analysis_python_V2/example/User_Guide.pdf |
There was a problem hiding this comment.
Pull Request Overview
Updates sco2 python functionality to support two new cycle configurations - recompression with HTR bypass (configuration 3) and turbine split flow (configuration 4).
- Adds design parameters for HTR bypass and turbine split flow configurations
- Updates plotting functionality to handle visualization of the new cycle configurations
- Refactors code to use configurable flags for saving outputs
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| design_point_examples.py | Adds new configuration parameters and implements configurable output saving |
| sco2_plots.py | Updates cycle plotting logic to support HTR BP and TSF configurations with proper state point mappings |
| sco2_cycle_ssc.py | Adds default parameters and cycle name handling for the new configurations |
Comments suppressed due to low confidence (1)
samples/CSP/sco2_analysis_python_V2/core/sco2_plots.py:1
- Corrected spelling of 'paramters' to 'parameters'.
# -*- coding: utf-8 -*-
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
Author
|
Update changelog tags when merged into develop. https://github.com/NREL/SAM/blob/sco2_py_samples/samples/CSP/sco2_analysis_python_V2/changelog.md |
tyneises
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update sco2 python examples and support functions to include new configurations - recompression with htr bypass and turbine split flow.
Corresponding branches and PRs:
wex, lk: develop
ssc: sco2_tsf
Linked to PR https://github.com/NREL/ssc/pull/1353
Unit Test Impact:
No change to unit tests; however there are new unit tests in ssc for the new sco2 configurations.
Checklist