Bug in yaw_optimizer_geometric.py

[ziyuwind]

In yaw_optimizer_geometric.py, there is a bug:
"in_Jensen_wake = (abs(y_dists) < spread * x_dists + rotor_diameter)"

According to the Stanely et al. (2023) https://wes.copernicus.org/articles/8/1341/2023/，
it should be "in_Jensen_wake = (abs(y_dists) < spread * x_dists + rotor_diameter/2.)"

[misi9170]

Thanks for the bug report @ziyuwind !

This line is the one mentioned. As you point out, the expression from Stanley et al., 2023 is $r_\text{wake} = 0.1x + r_\text{turbine}$ (see top paragraph of right column on page 1343). Here, $0.1$ is the spread and $r_\text{turbine}$ is the rotor radius (= rotor_diameter/2).

This bug was introduced during the implementation of the geometric yaw optimization in #681. I'll look around there to see if there are any reasons that this shouldn't simply be updated to correct the discrepancy.

[misi9170]

The implementation in #681 was originally based on this repository, but significantly refactored. It does appear that I introduced a bug in translating that code; in particular, this file seems to use the expected rotor_diameter/2.

I'll create a bugfix for this.