WaterUseEquipment naming rounds to not enough decimals

[jmarrec]

openstudio-standards/lib/openstudio-standards/service_water_heating/data/typical_water_use_equipment.json

Lines 405 to 420 in 95b8178

	{
	"space_type": "WholeBuilding - Sm Office",
	"building_type": "Office",
	"water_use_equipment": [
	{
	"equipment_name": null,
	"peak_flow_rate_gph": null,
	"peak_flow_rate_gph_per_floor_area_ft2": 0.000545256,
	"loop_type": "Shared",
	"mixed_water_temperature_f": 110.0,
	"flow_rate_schedule": "OfficeSmall BLDG_SWH_SCH",
	"sensible_fraction": 0.2,
	"latent_fraction": 0.05
	}
	]
	},

openstudio-standards/lib/openstudio-standards/service_water_heating/create_water_use.rb

Line 53 in 95b8178

water_use_def.setName("#{name} #{flow_rate_gpm.round(2)}gpm #{water_use_temperature_f.round}F")

In a 20.9m² / 225 ft² Small office space (from create_typical), I end up with 0.00 gpm in the name anyways.

OS:WaterUse:Equipment:Definition,
  {a91a5d93-f590-4f52-ad6b-f6b4c6e2be26}, !- Handle
  Office WholeBuilding - Sm Office C end_b - Story ground Water Use 0.00gpm 140F, !- Name
  ,                                       !- End-Use Subcategory
  1.29001155480017e-07,                   !- Peak Flow Rate {m3/s}
  {b10cc906-de03-482e-9359-980dac5fb52a}, !- Target Temperature Schedule Name
  {9d9b456c-93ab-4809-b420-e05bb3f68000}, !- Sensible Fraction Schedule Name
  {867c3006-ec7d-447e-95ec-7c3d001859eb}; !- Latent Fraction Schedule Name

I realize this commit changed it from round(1) to round(2), but still not enough:

5bf6289#diff-83ad2b82fb2f7058427359180e2e34ff134167e40518cf1cdaaa7c49a5196a34

---

Essentially If I trace what's going on (I'm in Python ATM, but same in Ruby)

# Json: peak_flow_rate_per_area = 0.000545256
peak_flow_rate_gal_per_hr_per_ft2 = 0.000545256

total_space_floor_area_m2 = 20.90318400000014
total_space_floor_area_ft2 = openstudio.convert(total_space_floor_area_m2, 'm^2', 'ft^2').get()

num_units = 1
peak_flow_rate_gal_per_hr = num_units * peak_flow_rate_gal_per_hr_per_ft2 * total_space_floor_area_ft2


peak_flow_rate_m3_per_s = openstudio.convert(peak_flow_rate_gal_per_hr, 'gal/hr', 'm^3/s').get()
flow_rate_gpm = openstudio.convert(peak_flow_rate_m3_per_s, 'm^3/s', 'gal/min').get()
print(f"{flow_rate_gpm}")
print(f"{flow_rate_gpm:.2f}gpm")

output:

0.002044710000000014
0.00gpm

[jmarrec]

I'm also looking for a way to recreate the former (0.4.0) model_add_typical_swh that would actually use the proper space type data instead of this typical_water_use_equipment.json that I cannot subclass whatsoever.

https://github.com/jmarrec/openstudio-standards/blob/8b1951a8ed4634861b8cfdc0f05056a3f31623ab/lib/openstudio-standards/prototypes/common/objects/Prototype.Model.swh.rb#L236-L257