Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format.h is broken and breaks CUDA compile #637

Open
cement-head opened this issue Feb 24, 2021 · 3 comments
Open

format.h is broken and breaks CUDA compile #637

cement-head opened this issue Feb 24, 2021 · 3 comments
Assignees
Labels
bug Something isn't working sdk Overall SDK related improvements
Milestone

Comments

@cement-head
Copy link

There's a misplaced set of quotes in format.h file that prevents CUDA integration into RAVEN (error2 build fail).:

This showed up when I was trying to compile RAVEN for CUDA in </raven/build/_deps/genomeworks-src/3rdparty/spdlog/include/spdlog/fmt/bundled/format.h>

Pulled solution from here: https://www.gitmemory.com/issue/yuzu-emu/yuzu/2597/507715224

Changed Line 3475 from:
FMT_CONSTEXPR internal::udl_formatter<Char, CHARS...> operator""_format() {

To (remove quotes):
FMT_CONSTEXPR internal::udl_formatter<Char, CHARS...> operator_format() {

@ahehn-nv
Copy link
Contributor

Hi @cement-head , thanks for reporting this issue!
I think this problem will be fixed in the upcoming release, since we removed the spdlog dependency in a711fca . Is it ok if I ask you to verify once the release is out?

@ahehn-nv ahehn-nv self-assigned this Feb 24, 2021
@ahehn-nv ahehn-nv added bug Something isn't working sdk Overall SDK related improvements labels Feb 24, 2021
@ahehn-nv ahehn-nv added this to the v0.6.0 milestone Feb 24, 2021
@cement-head
Copy link
Author

Yes please! @andorjkiss

@ahehn-nv
Copy link
Contributor

The new release is out: https://github.com/clara-parabricks/GenomeWorks/releases/tag/v2021.02.0
Could you give it another try with that release and check if the problem got fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sdk Overall SDK related improvements
Projects
None yet
Development

No branches or pull requests

2 participants