-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support memmap dataset with object store via Multi-Storage Client #12870
base: main
Are you sure you want to change the base?
Conversation
a3a4f18
to
7abef3f
Compare
Signed-off-by: jayya2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one question about MSC: if multistorageclient
is a package in the container (so that MULTISTORAGECLIENT_AVAILABLE =True
, but the environment is a normal file system, is there any impact to run multistorageclient functions
@cuichenx valid point, two things here:
|
Ah, having the first bullet point is perfect. (I realized you also put this in the description but I missed that earlier). |
Signed-off-by: Chen Cui <[email protected]>
Signed-off-by: Chen Cui <[email protected]>
Signed-off-by: cuichenx <[email protected]>
Signed-off-by: Chen Cui <[email protected]>
Important
The
Update branch
button must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add support for using multi-storage-client to load data from object store and construct memmap-based datasets.
In multi-storage client we provide adaptors such as
msc.numpy.*
andmsc.pickle.*
which can handle both object store URLs (starting withmsc://...
) and POSIX file path (/path/to/your/file
), so in theory, we can directly replaceexisting usages, for example
numpy.memmap(...)
withmsc.numpy.memmap(...)
.However multis-storage client is not a required dependency at the moment, so I pre-check the module availability to play it safe in this first introduction PR to multi-storage client library.
Collection: [NLP]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information