-
Notifications
You must be signed in to change notification settings - Fork 3.3k
add apply_chat_template method to TokenizerSpec + AutoTokenizer #12878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b392165
add apply_chat_template method
akoumpa c601e4e
fix
akoumpa d990378
add test
akoumpa ad41691
fix
akoumpa 51db77e
fix
akoumpa 8a0fdad
Apply isort and black reformatting
artbataev c83de0f
skip test if transformers not installed
akoumpa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import pytest | ||
| from nemo.collections.nlp.modules.common.tokenizer_utils import get_tokenizer | ||
|
|
||
|
|
||
| def test_chat_template(): | ||
| transformers = pytest.importorskip("transformers") | ||
| path = "/home/TestData/akoumparouli/tokenizer_with_chat_template/" | ||
| tokenizers = [get_tokenizer(path), transformers.AutoTokenizer.from_pretrained(path)] | ||
| prompt = "Give me a short introduction to pytest." | ||
| messages = [{"role": "system", "content": "You are a helpful CI assistant."}, {"role": "user", "content": prompt}] | ||
| texts = [ | ||
| tokenizer.apply_chat_template(messages, tokenize=False, add_generation_prompt=True) for tokenizer in tokenizers | ||
| ] | ||
| assert texts[0] == texts[1] | ||
|
|
||
|
|
||
| def test_throws_chat_template(): | ||
| path = "/home/TestData/akoumparouli/tokenizer_without_chat_template/" | ||
| tokenizer = get_tokenizer(path) | ||
| prompt = "Give me a short introduction to pytest." | ||
| messages = [{"role": "system", "content": "You are a helpful CI assistant."}, {"role": "user", "content": prompt}] | ||
| try: | ||
| tokenizer.apply_chat_template(messages, tokenize=False, add_generation_prompt=True) | ||
| except ValueError as e: | ||
| assert 'Cannot use chat template functions because tokenizer.chat_template is not set' in str(e) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.