-
Notifications
You must be signed in to change notification settings - Fork 257
Open
Labels
Description
Describe the bug
Currently we have a lot of code like
private val ansiEnabled = SQLConf.get.ansiEnabled
...
GpuAdd(lhs, rhs, failOnError = ansiEnabled)
But this is not correct. In 3.2.1, there is a failOnError boolean, that could be set to true or false outside of actual ANSI mode.
In 3.4.0 this was updated to have an EvalMode, which again could be set ignoring the configuration value.
If we are going to do this correctly we need to check for ANSI mode looking at individual expressions and not the config that is set. I know this is much more difficult to do because the code will not be generic, but the code is technically wrong if we don't do this.