From 81d52bab66afd824e8dca6604514d0e422ae928b Mon Sep 17 00:00:00 2001
From: yijie4188 <yijie4188@gmail.com>
Date: Sun, 11 Aug 2024 00:08:01 +0800
Subject: [PATCH] feat(core): add icon for completion items

---
 packages/core/src/plugins/expression-quick-completions.ts | 3 +++
 packages/core/src/plugins/provide-completions/index.ts    | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/packages/core/src/plugins/expression-quick-completions.ts b/packages/core/src/plugins/expression-quick-completions.ts
index fab7ea8..f4cda09 100644
--- a/packages/core/src/plugins/expression-quick-completions.ts
+++ b/packages/core/src/plugins/expression-quick-completions.ts
@@ -1,5 +1,6 @@
 import { definePlugin } from '@shikitor/core'
 import type {} from '@shikitor/core/plugins/provide-completions'
+import { CompletionItemKind } from '@shikitor/core/plugins/provide-completions'
 
 export default definePlugin({
   name: 'expression-quick-completions',
@@ -32,12 +33,14 @@ export default definePlugin({
             return {
               suggestions: [
                 {
+                  kind: CompletionItemKind.Operator,
                   label: 'par',
                   detail: '(expr)',
                   range,
                   insertText: `(${expressionStr})`
                 },
                 {
+                  kind: CompletionItemKind.Operator,
                   label: 'not',
                   detail: '!expr',
                   range,
diff --git a/packages/core/src/plugins/provide-completions/index.ts b/packages/core/src/plugins/provide-completions/index.ts
index 105c0e6..1e2e470 100644
--- a/packages/core/src/plugins/provide-completions/index.ts
+++ b/packages/core/src/plugins/provide-completions/index.ts
@@ -117,9 +117,10 @@ function completionItemTemplate(
   index: number
 ) {
   const { prefix } = completionItemTemplate
+  const kind = item.kind ? CompletionItemKind[item.kind]?.[0] ?? 'U' : 'U'
   return `
     <div class="${classnames(prefix, selectedIndex === index && 'selected')}" data-index="${index}">
-      <div class="${prefix}__kind">${item.kind ? CompletionItemKind[item.kind][0] : 'U'}</div>
+      <div class="${prefix}__kind">${kind}</div>
       <div class="${prefix}__label">${highlightingKeyword(item.label, keywordParts)}</div>
       ${item.detail ? `<div class="${prefix}__detail">${item.detail}</div>` : ''}
       ${item.documentation ? `<div class="${prefix}__documentation">${item.documentation}</div>` : ''}