Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Cyclomedia's distribution; upgrade to 18.4 #2

Closed
wants to merge 1 commit into from
Closed

Use Cyclomedia's distribution; upgrade to 18.4 #2

wants to merge 1 commit into from

Conversation

allthesignals
Copy link
Collaborator

@allthesignals allthesignals commented Oct 26, 2021 •
edited
Loading

This PR makes two changes:

  1. Uses Cyclomedia's own hosted distribution of their JavaScript API library.
  2. Upgrades from version 17 to 18.4 to fix and close Upgrade Cyclomedia API to latest version 18.4 labs-zola#971.

Note: I tried to upgrade to the very latest version but there were breaking changes.

@allthesignals allthesignals requested a review from a team as a code owner October 26, 2021 21:38
@allthesignals allthesignals mentioned this pull request Oct 26, 2021
Open
@allthesignals
Copy link
Collaborator Author

@TylerMatteo if you have a sec for review :)

Some deployment notes:
The production version of this repo still points to 45.55.119.18 which I believe is the old dokku service. This should probably be re-deployed into Heroku, otherwise we won't really be able to push new changes out.

@dhochbaum-dcp
Copy link
Contributor

Closing this PR, upgrade to an even newer branch happened in PR #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Cyclomedia API to latest version 18.4
2 participants
@allthesignals @dhochbaum-dcp