Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create more elegant 404 error page for application for items not found #57

Open
andrewbattista opened this issue Nov 22, 2019 · 1 comment
Assignees
Labels
First timer A good issue for someone completely new to take on look and feel enhancements look-feel or wording changes / improvements new-feature

Comments

@andrewbattista
Copy link
Contributor

Right now, we have a fairly crude error page that doesn't diverge too much from the default. We should make it more elegant and in-line with NYU Libraries pages

@andrewbattista andrewbattista added look and feel enhancements look-feel or wording changes / improvements new-feature labels Nov 22, 2019
@andrewbattista andrewbattista added this to the Winter 2020 Sprint milestone Nov 22, 2019
@andrewbattista andrewbattista added the First timer A good issue for someone completely new to take on label Nov 22, 2019
@nmwolf
Copy link
Collaborator

nmwolf commented Jan 7, 2020

Looks like we will have to consider two approaches here: alter the static 404.html page that is currently used (found in public folder) so that it looks more branded, or perform a full rails workflow to create a 404 page like it does any other application page (but produced only when a user enters a URL for a nonexistent page). The advantage to the way it works now is that it puts the lifting (I think) on the server, not the rails application, to recognize and produce the 404 when required. But if we do this using a static file, it may need updating from time to time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First timer A good issue for someone completely new to take on look and feel enhancements look-feel or wording changes / improvements new-feature
Projects
None yet
Development

No branches or pull requests

2 participants