[FINNA-855] Display a warning in online payment about a recently started transaction.

Does not prevent starting the payment process again but warns about it.

Author: EreMaijala

local/languages/finna/en-gb.ini

@@ -720,6 +720,7 @@ online_payment_failed = "Payment failed"
 online_payment_fines_changed = "Fines list has been updated after previous page load."
 online_payment_fines_contain_nonpayable_fees = "You have fees that cannot be paid online. Contact library customer service."
 online_payment_go_to_pay = "Pay online %%amount%%"
+online_payment_in_progress_warning = "Earlier payment was started at %%startDateTime%%. Start a new payment only if the earlier one was interrupted."
 online_payment_minimum_fee = "Minimum amount of online payment"
 online_payment_nonpayable_fees = "This fee cannot be paid online"
 online_payment_payable_online = "Payable online"

local/languages/finna/fi.ini

@@ -759,6 +759,7 @@ online_payment_failed = "Maksutapahtuma epäonnistui."
 online_payment_fines_changed = "Maksulista on päivittynyt edellisen sivunlatauksen jälkeen."
 online_payment_fines_contain_nonpayable_fees = "Sinulla on maksuja, joita ei voi maksaa verkkomaksuna. Ota yhteyttä kirjaston asiakaspalveluun."
 online_payment_go_to_pay = "Siirry maksamaan %%amount%%"
+online_payment_in_progress_warning = "Aiempi maksutapahtuma aloitettu %%startDateTime%%. Aloita maksaminen uudelleen vain, jos edellinen tapahtuma keskeytyi."
 online_payment_minimum_fee = "Verkkomaksamisen minimisumma"
 online_payment_nonpayable_fees = "Tätä maksua ei voi maksaa verkossa"
 online_payment_payable_online = "Maksettavissa verkossa"

local/languages/finna/sv.ini

@@ -703,6 +703,7 @@ online_payment_failed = "Betalning mislyckades"
 online_payment_fines_changed = "Avgiftslistan har uppdaterats efter föregående sidhämtning."
 online_payment_fines_contain_nonpayable_fees = "Du har avgifter som inte kan betalas på nätet. Kontakta bibliotekets kundtjänst."
 online_payment_go_to_pay = "Betala på nätet %%amount%%"
+online_payment_in_progress_warning = "Tidigare betalning startade vid %%startDateTime%%. Starta en ny betalning endast om den tidigare avbröts."
 online_payment_minimum_fee = "Det minsta beloppet som kan betalas på nätet"
 online_payment_nonpayable_fees = "Denna avgift kan inte betalas på nätet"
 online_payment_payable_online = "Kan betalas på nätet"

module/Finna/src/Finna/Controller/FinnaOnlinePaymentControllerTrait.php

@@ -416,6 +416,12 @@ protected function handleOnlinePayment($patron, $fines, $view)
                         'Helpers/OnlinePayment/terms-' . $view->paymentHandler
                         . '.phtml'
                     );
+                } else {
+                    // Check for a started transaction:
+                    $view->startedTransaction = $trTable->getStartedPayment(
+                        $patron['cat_username'],
+                        (int)($paymentConfig['transactionMaxDuration'] ?? 15)
+                    );
                 }
             }
         }

module/Finna/src/Finna/Db/Table/Transaction.php

@@ -90,7 +90,7 @@ public function __construct(
      * @param int    $transactionFee Transaction fee
      * @param string $currency       Currency
      *
-     * @return Finna\Db\Row\Transaction
+     * @return TransactionRow
      */
     public function createTransaction(
         $id,
@@ -116,12 +116,36 @@ public function createTransaction(
         return $t;
     }
 
+    /**
+     * Check if payment is started for the patron, but not progressed further.
+     *
+     * Payment is not permitted if:
+     *   - patron has a transaction with "in progress" status and maximum duration
+     *     has not been reached
+     *
+     * @param string $patronId               Patron's Catalog username (barcode)
+     * @param int    $transactionMaxDuration Max duration for a transaction in minutes
+     *
+     * @return TransactionRow|null Current transaction or null if not started
+     */
+    public function getStartedPayment(string $patronId, int $transactionMaxDuration): ?TransactionRow
+    {
+        $callback = function ($select) use ($patronId, $transactionMaxDuration) {
+            $select->where->equalTo('cat_username', $patronId);
+            $select->where->equalTo('complete', self::STATUS_PROGRESS);
+            $select->where(
+                "NOW() < DATE_ADD(created, INTERVAL $transactionMaxDuration MINUTE)"
+            );
+        };
+
+        return $this->select($callback)->current();
+    }
+
     /**
      * Check if payment is in progress for the patron.
      *
      * Payment is not permitted if:
-     *   - patron has a transaction in progress and translation maximum duration
-     *     has not been exceeded
+     *   - patron has a transaction in progress
      *   - patron has a paid transaction that has not been registered as paid
      *     to the ILS
      *

themes/finna2/templates/myresearch/fines.phtml

@@ -113,6 +113,11 @@
             </p>
           </div>
         <?php endif; ?>
+        <?php if ($this->startedTransaction): ?>
+          <div class="alert alert-danger">
+            <?=$this->transEsc('online_payment_in_progress_warning', ['%%startDateTime%%' => $this->dateTime()->convertToDisplayDateAndTime('Y-m-d H:i:s', $this->startedTransaction->created)]); ?>
+          </div>
+        <?php endif; ?>
       <?php endif; ?>
     </div>
     <?php if ($this->onlinePayment): ?>