[FINNA-3834] LIDO: Improve handling of type and pref attributes (#183)

Author: mshroom

src/RecordManager/Base/Record/Lido.php

@@ -115,6 +115,13 @@ class Lido extends AbstractRecord
      */
     protected $subjectConceptIDTypes = ['uri', 'url'];
 
+    /**
+     * Title types for preferred titles.
+     *
+     * @var array
+     */
+    protected $preferredTitleTypes = ['preferred'];
+
     /**
      * Repository location types to be included.
      *
@@ -486,13 +493,13 @@ protected function getTitles()
                 if (!($title = trim((string)$appellationValue))) {
                     continue;
                 }
-                $preference = (string)$appellationValue['pref'] ?: 'preferred';
+                $preference = mb_strtolower((string)($appellationValue->attributes()->pref ?? 'preferred'), 'UTF-8');
                 $titleLang = $this->getInheritedXmlAttribute(
                     $appellationValue,
                     'lang',
                     $defaultLanguage
                 );
-                if ('preferred' === $preference) {
+                if (in_array($preference, $this->preferredTitleTypes)) {
                     $preferredParts[$titleLang][] = $title;
                 } else {
                     $alternateParts[$titleLang][] = $title;
@@ -1341,7 +1348,7 @@ protected function getRepositoryLocations(): array
             $this->doc->lido->descriptiveMetadata->objectIdentificationWrap->repositoryWrap->repositorySet
             ?? [] as $set
         ) {
-            $type = (string)($set->attributes()->type ?? '');
+            $type = mb_strtolower((string)($set->attributes()->type ?? ''), 'UTF-8');
             if ($this->repositoryLocationTypes && !in_array($type, $this->repositoryLocationTypes)) {
                 continue;
             }