Upgrade to protobuf 3.25.5 #3200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I think I might need to include the protobufs
|
Collaborator
|
its hard to know if the changes to the generated classes are safe or not... any suggestion on this process? |
Collaborator
Author
|
This will require some comprehensive integration testing.
…On Tue, Sep 23, 2025 at 7:48 PM FineAndDandy ***@***.***> wrote:
*FineAndDandy* left a comment (NationalSecurityAgency/datawave#3200)
<#3200 (comment)>
its hard to know if the changes to the generated classes are safe or
not... any suggestion on this process?
—
Reply to this email directly, view it on GitHub
<#3200 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3CSVXLKCPZ65VKWKSSK33UHL45AVCNFSM6AAAAACHJISSC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMRVHEYTENRQG4>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Collaborator
|
a bit of a random question, but with the change in versions of protobuf do the .proto files in datawave-ws-client and datawave-core need to adjust syntax in any way in order to be compatible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.