Make FieldExistenceRule check for hidden fields #3264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschmidt10
reviewed
Nov 5, 2025
core/utils/metadata-utils/src/test/java/datawave/query/util/MetadataHelperTest.java
Outdated
Show resolved
Hide resolved
jschmidt10
reviewed
Nov 5, 2025
core/utils/metadata-utils/src/main/java/datawave/query/util/MetadataHelper.java
Outdated
Show resolved
Hide resolved
jschmidt10
previously approved these changes
Nov 6, 2025
jschmidt10
reviewed
Nov 6, 2025
core/utils/metadata-utils/src/test/java/datawave/query/util/MetadataHelperTest.java
Outdated
Show resolved
Hide resolved
lbschanno
requested changes
Nov 24, 2025
warehouse/query-core/src/test/java/datawave/query/rules/FieldExistenceRuleTest.java
Outdated
Show resolved
Hide resolved
...use/query-core/src/main/java/datawave/query/jexl/visitors/FieldMissingFromSchemaVisitor.java
Outdated
Show resolved
Hide resolved
lbschanno
requested changes
Dec 3, 2025
| * @throws TableNotFoundException | ||
| * if the table does not exist | ||
| */ | ||
| public Set<String> getHiddenFields(Set<String> ingestTypeFilter) throws TableNotFoundException { |
Collaborator
There was a problem hiding this comment.
It may be beneficial to make this method cacheable as well with @Cacheable.
| */ | ||
| @Cacheable(value = "loadHiddenFields", key = "{#root.target.auths,#root.target.metadataTableName}", cacheManager = "metadataHelperCacheManager", | ||
| sync = true) | ||
| public Multimap<String,String> loadHiddenFields() throws TableNotFoundException { |
Collaborator
There was a problem hiding this comment.
Can you add a unit test for this method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query validation rule,
FieldExistenceRule, will now check for hidden fields. If a field is hidden, it will be treated as non-existent.