Skip to content

FloatCycleGroup is missing longdouble datatype #7192

Closed
@Wall-AF

Description

@Wall-AF

Describe the bug
When cycling through the floating point dataypes in the data section of the Listing Panel, the datatype longdouble is missing from the cycle.

To Reproduce
Steps to reproduce the behavior:

  1. Pick any application to RE.
  2. Find some data area.
  3. Press key f several times to cycle through the floating point datatypes.
  4. See float and double, but no longdouble!

Expected behavior
All floating point dataypes should be cycled through.

Screenshots
N/A.

Attachments
N/A.

Environment (please complete the following information):

  • OS: Windows 11
  • Java Version: Temurin-21.0.3+9
  • Ghidra Version: 11.3-DEV
  • Ghidra Origin: locally built

Additional context
Update the constructor of Java class FloatCycleGroup to the following to solve the issue:

	private static class FloatCycleGroup extends CycleGroup {
		public FloatCycleGroup() {
			super("Cycle: float,double,longdouble");
			addDataType(new FloatDataType());
			addDataType(new DoubleDataType());
			addDataType(new LongDoubleDataType());

			defaultKeyStroke = KeyStroke.getKeyStroke(KeyEvent.VK_F, 0);
		}
	}

Metadata

Metadata

Assignees

Labels

Status: InternalThis is being tracked internally by the Ghidra team

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions