Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FloatCycleGroup is missing longdouble datatype #7192

Open
Wall-AF opened this issue Nov 14, 2024 · 0 comments
Open

FloatCycleGroup is missing longdouble datatype #7192

Wall-AF opened this issue Nov 14, 2024 · 0 comments

Comments

@Wall-AF
Copy link

Wall-AF commented Nov 14, 2024

Describe the bug
When cycling through the floating point dataypes in the data section of the Listing Panel, the datatype longdouble is missing from the cycle.

To Reproduce
Steps to reproduce the behavior:

  1. Pick any application to RE.
  2. Find some data area.
  3. Press key f several times to cycle through the floating point datatypes.
  4. See float and double, but no longdouble!

Expected behavior
All floating point dataypes should be cycled through.

Screenshots
N/A.

Attachments
N/A.

Environment (please complete the following information):

  • OS: Windows 11
  • Java Version: Temurin-21.0.3+9
  • Ghidra Version: 11.3-DEV
  • Ghidra Origin: locally built

Additional context
Update the constructor of Java class FloatCycleGroup to the following to solve the issue:

	private static class FloatCycleGroup extends CycleGroup {
		public FloatCycleGroup() {
			super("Cycle: float,double,longdouble");
			addDataType(new FloatDataType());
			addDataType(new DoubleDataType());
			addDataType(new LongDoubleDataType());

			defaultKeyStroke = KeyStroke.getKeyStroke(KeyEvent.VK_F, 0);
		}
	}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant