Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop containers when stopping groundseg service #600

Open
neonfuz opened this issue Nov 27, 2023 · 4 comments
Open

Stop containers when stopping groundseg service #600

neonfuz opened this issue Nov 27, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@neonfuz
Copy link
Contributor

neonfuz commented Nov 27, 2023

Right now when you stop the groundseg service, all of the auxiliary containers continue running. It would be nice to have some way to stop all the related containers, while keeping my other containers running. I propose stopping containers when the groundseg service is stopped, but some other way such as a command the user can issue would be ok too.

@mopfel-winrux
Copy link
Contributor

We don't stop the containers when GS service is stopped because it would mean that your urbit shutdown whenever GS is updated and that is bad UX. I do think we should have a way to shutdown all containers

@neonfuz
Copy link
Contributor Author

neonfuz commented Nov 27, 2023

That makes sense

@neonfuz
Copy link
Contributor Author

neonfuz commented Nov 29, 2023

@mopfel-winrux
A thought: maybe it makes sense to bind systemctl restart groundseg and or systemctl reload groundseg to not stop the containers, but make systemctl stop groundseg stop them, and rewrite the update routines to use one of the first two commands

@nallux-dozryl
Copy link
Contributor

@neonfuz a little late to the convo but we need restart and stop to function the way it does now. This should be a CLI command though. Eg: groundseg stop-containers

@nallux-dozryl nallux-dozryl added the enhancement New feature or request label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

3 participants