Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge light-hotspot branch into production #163

Open
marvinmarnold opened this issue May 24, 2022 · 0 comments
Open

Merge light-hotspot branch into production #163

marvinmarnold opened this issue May 24, 2022 · 0 comments
Assignees
@marvinmarnold @pritamghanghas
Labels
device device releated tickets light miner

Comments

@marvinmarnold
Copy link
Contributor

marvinmarnold commented May 24, 2022 •
edited by pritamghanghas
Loading

Keeping separate branch of light-hotspot adds a lot of overhead to keep the hashes current in light miner branches. We can merge it to master after adding jsonrpc back. As that is the only breaking change between the two.

Acceptance Criterion

  • Support both jsonrpc and grpc clients for helium miner/gateway
@marvinmarnold marvinmarnold added the device device releated tickets label May 24, 2022
@pritamghanghas pritamghanghas self-assigned this May 26, 2022
@marvinmarnold marvinmarnold self-assigned this Aug 17, 2022
pritamghanghas added a commit that referenced this issue Aug 25, 2022
@pritamghanghas
feat: Merge light-hotspot branch into production #163
7fed19a 
* bring back json rpc client so that pyhelper remains compatible
with both miner and gateway client API during transition.
This was referenced Aug 25, 2022
Closed
Merged
pritamghanghas added a commit that referenced this issue Aug 26, 2022
@pritamghanghas
feat: Merge light-hotspot branch into production #163
d638625 
* bring back json rpc client so that pyhelper remains compatible
with both miner and gateway client API during transition.
pritamghanghas added a commit that referenced this issue Aug 26, 2022
@pritamghanghas
feat: Merge light-hotspot branch into production #163 (#185)
19255b0 
* bring back json rpc client so that pyhelper remains compatible
with both miner and gateway client API during transition.
@pritamghanghas pritamghanghas mentioned this issue Aug 30, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvinmarnold marvinmarnold

@pritamghanghas pritamghanghas

Labels
device device releated tickets light miner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marvinmarnold @pritamghanghas