Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate gateway-rs api changes #179

Open
pritamghanghas opened this issue Jun 29, 2022 · 0 comments
Open

Incorporate gateway-rs api changes #179

pritamghanghas opened this issue Jun 29, 2022 · 0 comments
Labels
device device releated tickets light miner

Comments

@pritamghanghas
Copy link
Contributor

Verify all API changes in gateway-rs grpc and modify hm-pyhelper's gateway_grpc client accordingly.
Remove the current method of extracting version from dpkg won't work as the client side which will be mostly diagnostic container will not have the gateway-rs installed.
The height_res message also returns the connected gateway's miner version, include this in summary. we keep it similar to info cli method.

Acceptance Criterion

  • remove the version fetching from dpkg.
  • expose any additional data from grpc like validator's version number.
  • figure out a way of getting gateway-rs version info.
    • we can patch gateway-rs to expose to version information and submit the patch upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
device device releated tickets light miner
Projects
None yet
Development

No branches or pull requests

2 participants