Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possibility to combine get_ecc_location and get_onboarding_location #239

Open
shawaj opened this issue Apr 7, 2023 · 0 comments
Open

possibility to combine get_ecc_location and get_onboarding_location #239

shawaj opened this issue Apr 7, 2023 · 0 comments

Comments

@shawaj
Copy link
Member

shawaj commented Apr 7, 2023 •
edited
Loading

Related to #228 and #221 and #231 and #229

possibility to combine get_ecc_location and get_onboarding_location to reduce lines of code and complexity as it is mostly repeated.

#231 will make them diverge somewhat but the core key finding part will be the same the only difference will be how it polls the helium onboarding server or the public api etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shawaj