Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

did_gateway_mfr_test_result_include_miner_key_pass - does not use correct slot #254

Open
shawaj opened this issue Apr 24, 2023 · 0 comments

Comments

@shawaj
Copy link
Member

shawaj commented Apr 24, 2023

As per this function:

def did_gateway_mfr_test_result_include_miner_key_pass(
gateway_mfr_test_result
):
"""
Returns true if gateway_mfr_test_result["tests"] has an key "miner_key(0)" with value
being a dict that contains result key value set to pass.
{
'result': 'pass',
'tests': 'miner_key(0)': {'result': 'pass'}
}
"""
return gateway_mfr_test_result.get(
'tests', {}).get('miner_key(0)', {}).get('result', 'fail') == 'pass'

The did_gateway_mfr_test_result_include_miner_key_pass only checks slot 0.

If the slot is 2 for example the key in the output will be miner_key(2) and this will fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant