Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Accept --target flag #41

Closed
wants to merge 3 commits into from
Closed

WIP: Accept --target flag #41

wants to merge 3 commits into from

Conversation

Nemo157
Copy link
Owner

@Nemo157 Nemo157 commented Mar 11, 2018

Will fix #39

@thomcc
Copy link

thomcc commented May 3, 2019

I rebased this at https://github.com/thomcc/cargo-lichking/tree/target-flag (and deleted the println's) and it seems to work (in some fairly limited tests, but enough for my uses).

Not sure what prevented this from landing

@Nemo157
Copy link
Owner Author

Nemo157 commented May 3, 2019

I think the main thing I wanted to do was add tests for it, but the sheer amount of setup required to effectively test it was overwhelming. I was going to come back to do it, but then just didn't.

At this point, if it appears to be working for you feel free to open a new PR with the rebased changes and I'll merge it (and probably add some more text to the help saying that it's less guaranteed to work correctly).

@Nemo157 Nemo157 closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target flag for target specific dependencies
2 participants