Codecov Report

Attention: Patch coverage is 96.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.34%. Comparing base (070ea63) to head (ae49289).

@@           Coverage Diff           @@
##           master    #1947   +/-   ##
=======================================
  Coverage   88.34%   88.34%           
=======================================
  Files         124      124           
  Lines       31404    31429   +25     
=======================================
+ Hits        27743    27767   +24     
- Misses       3661     3662    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Test fails:

  Expression: is_unit(a) == is_unit(a ^ 2)
  function is_unit is not implemented for argument
  PBWAlgQuoElem{QQFieldElem, Singular.n_Q}: 1//3*a^2*h^2*f^3*e^3 + 3//2*a^3*h^2*f^2*e^3 + 1//2*a^2*h^3*f*e^2

Perhaps someone (@JohnAAbbott ?) can look into adding that method next year.

In the meantime we could make the test conditional here and skip it if a not-implemented-exception is thrown...

@fieker @thofma @lgoettgens just talking to @JohnAAbbott whether we can implement is_unit for PBWAlgQuoElem and, well, it is non-trivial.

So we probably should not insist on this being available. But what would be a good strategy to have such tests (they are useful, I found several bugs in our current code with them!) but allow some rings to opt-out of them because they don't implement a certain feature?