Skip to content

Commit 3ae7427

Browse files
committed
fix: remove 4xx response code (like 404) from sw cache
In case the service gateway got failed and returns a 4xx error code other than 5xx, or a package is published just now but not cached
1 parent 4505e3d commit 3ae7427

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

packages/app/config/webpack.prod.js

+14
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ const publicPath = '/';
2222
// .trim() === 'master';
2323

2424
const normalize = normalizeName({ name: true, automaticNameDelimiter: '~' });
25+
const successResponses = /^0|([123]\d\d)$/;
2526

2627
module.exports = merge(commonConfig, {
2728
devtool: 'source-map',
@@ -145,6 +146,7 @@ module.exports = merge(commonConfig, {
145146
maxEntries: 300,
146147
name: 'unpkg-cache',
147148
},
149+
successResponses,
148150
},
149151
},
150152
{
@@ -155,6 +157,7 @@ module.exports = merge(commonConfig, {
155157
maxEntries: 20,
156158
name: 'cloudflare-cache',
157159
},
160+
successResponses,
158161
},
159162
},
160163
{
@@ -165,6 +168,7 @@ module.exports = merge(commonConfig, {
165168
maximumFileSizeToCacheInBytes: 1024 * 1024 * 100, // 100mb
166169
name: 'vscode',
167170
},
171+
successResponses,
168172
},
169173
},
170174
{
@@ -175,6 +179,7 @@ module.exports = merge(commonConfig, {
175179
maximumFileSizeToCacheInBytes: 1024 * 1024 * 100, // 100mb
176180
name: 'vscode-extensions',
177181
},
182+
successResponses,
178183
},
179184
},
180185
],
@@ -237,6 +242,7 @@ module.exports = merge(commonConfig, {
237242
maxAgeSeconds: 60 * 60 * 24,
238243
name: 'dependency-version-cache',
239244
},
245+
successResponses,
240246
},
241247
},
242248
{
@@ -250,6 +256,7 @@ module.exports = merge(commonConfig, {
250256
maxAgeSeconds: 60 * 60 * 24,
251257
name: 'static-root-cache',
252258
},
259+
successResponses,
253260
},
254261
},
255262
{
@@ -261,6 +268,7 @@ module.exports = merge(commonConfig, {
261268
maxAgeSeconds: 60 * 60 * 24 * 7,
262269
name: 'dependency-url-generator-cache',
263270
},
271+
successResponses,
264272
},
265273
},
266274
{
@@ -272,6 +280,7 @@ module.exports = merge(commonConfig, {
272280
maxAgeSeconds: 60 * 60 * 24 * 7,
273281
name: 'dependency-files-cache',
274282
},
283+
successResponses,
275284
},
276285
},
277286
// We resolve `package.json` to resolve versions (e.g. next -> 15.0.5). We need to have a much shorter cache on this
@@ -284,6 +293,7 @@ module.exports = merge(commonConfig, {
284293
name: 'unpkg-dep-pkg-cache',
285294
maxAgeSeconds: 60 * 5, // 5 minutes
286295
},
296+
successResponses,
287297
},
288298
},
289299
{
@@ -295,6 +305,7 @@ module.exports = merge(commonConfig, {
295305
name: 'unpkg-dep-cache',
296306
maxAgeSeconds: 60 * 60 * 24 * 7,
297307
},
308+
successResponses,
298309
},
299310
},
300311
{
@@ -306,6 +317,7 @@ module.exports = merge(commonConfig, {
306317
name: 'rawgit-cache',
307318
maxAgeSeconds: 60 * 60 * 24 * 7,
308319
},
320+
successResponses,
309321
},
310322
},
311323
{
@@ -317,6 +329,7 @@ module.exports = merge(commonConfig, {
317329
name: 'jsdelivr-dep-cache',
318330
maxAgeSeconds: 60 * 60 * 24 * 7,
319331
},
332+
successResponses,
320333
},
321334
},
322335
{
@@ -328,6 +341,7 @@ module.exports = merge(commonConfig, {
328341
name: 'cloudflare-cache',
329342
maxAgeSeconds: 60 * 60 * 24 * 7,
330343
},
344+
successResponses,
331345
},
332346
},
333347
],

0 commit comments

Comments
 (0)