Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support saving files to the server #189

Open
TheBizzle opened this issue Feb 4, 2015 · 8 comments
Open

Support saving files to the server #189

TheBizzle opened this issue Feb 4, 2015 · 8 comments

Comments

@TheBizzle
Copy link
Member

I believe that this will also require user accounts and permissioning (since many people seem hesitant about making their work-in-progress models available to the public). Or maybe the initial draft of this should just upload all files into one central pool...?

We should also think about restrictions for what can and can't be uploaded. We don't really want people uploading any old thing they feel like putting on the server. What should the size limit be? Do we need to check that the file is a valid '.nlogo' file? Should we verify that the model passes the compiler before accepting it? (Probably not.)

@mrerrormessage
Copy link
Contributor

Would it be acceptable to use localStorage instead? That would allow users to keep the file on their computer so that they didn't have to reopen it every time without making us liable for storage (and backup and security and authorization) of user data. We could even make something that shows users all the Tortoise files they've used up to this point, making switching between them really easy.

@qiemem
Copy link
Member

qiemem commented Feb 5, 2015

I think localStorage plus "upload" and "download" buttons (that really just puts the file in the browser/takes it out of) to allow transferring files between computers would be sufficient, especially in the short term. localStorage is super easy to work with.

@TheBizzle
Copy link
Member Author

That works for me.

@hirokiterashima
Copy link

Sounds great. Are you thinking about adding versioning support (undo, revert to point X, etc) at some point, or do you see this as something separate from the tool?

@TheBizzle
Copy link
Member Author

It would definitely be good to have user file versioning at some point, but I think that can wait. And, fortunately, the Code tab that currently exists for Tortoise authoring already supports "undo" operations.

@SethTisue
Copy link
Contributor

how about working with @reuven to keep the models on the Modeling Commons?

@qiemem
Copy link
Member

qiemem commented Feb 5, 2015

Good idea @SethTisue.

I think we should have the localStorage thing in place no matter what, just as a convenience. It lets you do "starts up where left off" and such things easily.

@TheBizzle
Copy link
Member Author

There are a lot of good long-term ideas here. I think that we would be wise to keep them in mind going forward, but, for now, what we need the most is a basic solution that allows people to save and open code that they wrote in Tortoise. Consequently, I've split the local storage stuff off into a separate ticket (#193) that should be given priority.

@TheBizzle TheBizzle changed the title Tortoise should support saving files to the server Support saving files to the server Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants