Add FT to bypass add optimization

Author: Shih-Hao Yeh

evcache-core/src/main/java/com/netflix/evcache/EVCacheImpl.java

@@ -114,6 +114,8 @@ public class EVCacheImpl implements EVCache, EVCacheImplMBean {
     private final Property<String> alias;
     private final Property<String> encoderBase;
 
+    private final Property<Boolean> bypassAddOpt;
+
     EVCacheImpl(String appName, String cacheName, int timeToLive, Transcoder<?> transcoder, boolean enableZoneFallback,
             boolean throwException, EVCacheClientPoolManager poolManager) {
         this._appName = appName;
@@ -170,6 +172,9 @@ public class EVCacheImpl implements EVCache, EVCacheImplMBean {
         // auto key prepend with appname for duet feature.
         this.maxKeyLength = propertyRepository.get(_appName + ".max.key.length", Integer.class).orElseGet("evcache.max.key.length").orElse(200);
 
+        // bypass short-circuit optimization
+        this.bypassAddOpt = propertyRepository.get(_appName + ".bypass.add.opt", Boolean.class).orElse(false);
+
         // if alias changes, refresh my pool to point to the correct alias app
         this.alias = propertyRepository.get("EVCacheClientPoolManager." + appName + ".alias", String.class);
         this.alias.subscribe(i -> {
@@ -3322,7 +3327,7 @@ protected <T> EVCacheLatch add(String key, T value, Transcoder<T> tc, int timeTo
                 cd = _pool.getEVCacheClientForRead().getTranscoder().encode(value);
             }
             if (clientUtil == null) clientUtil = new EVCacheClientUtil(_appName, _pool.getOperationTimeout().get());
-            latch = clientUtil.add(evcKey, cd, evcacheValueTranscoder, timeToLive, policy, clients, latchCount, fixup);
+            latch = clientUtil.add(evcKey, cd, evcacheValueTranscoder, timeToLive, policy, clients, latchCount, fixup, bypassAddOpt.get());
             if (event != null) {
                 event.setTTL(timeToLive);
                 event.setCachedData(cd);

evcache-core/src/main/java/com/netflix/evcache/pool/EVCacheClientUtil.java

@@ -49,7 +49,7 @@ public EVCacheClientUtil(String appName, long operationTimeout) {
     /**
      * TODO : once metaget is available we need to get the remaining ttl from an existing entry and use it
      */
-    public EVCacheLatch add(EVCacheKey evcKey, final CachedData cd, Transcoder evcacheValueTranscoder, int timeToLive, Policy policy, final EVCacheClient[] clients, int latchCount, boolean fixMissing) throws Exception {
+    public EVCacheLatch add(EVCacheKey evcKey, final CachedData cd, Transcoder evcacheValueTranscoder, int timeToLive, Policy policy, final EVCacheClient[] clients, int latchCount, boolean fixMissing, boolean bypassAddOpt) throws Exception {
         if (cd == null) return null;
 
         final EVCacheLatchImpl latch = new EVCacheLatchImpl(policy, latchCount, _appName);
@@ -73,7 +73,7 @@ public EVCacheLatch add(EVCacheKey evcKey, final CachedData cd, Transcoder evcac
             if(fixMissing) {
                 boolean status = f.get().booleanValue();
                 if(!status) { // most common case
-                    if(firstStatus == null) {
+                    if(firstStatus == null && !bypassAddOpt) {
                         for(int i = 0; i < clients.length; i++) {
                             latch.countDown();
                         }