Skip to content

Commit 169baf4

Browse files
authored
fix(signal): guard against object not found when recording changes (#5858)
1 parent d0fae16 commit 169baf4

File tree

1 file changed

+15
-4
lines changed

1 file changed

+15
-4
lines changed

src/dispatch/signal/service.py

+15-4
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,9 @@ def update(
582582
db_session=db_session, service_id=signal_in.oncall_service.id
583583
)
584584
if signal.oncall_service != oncall_service:
585-
updates["oncall_service"] = f"{signal.oncall_service.name} -> {oncall_service.name}"
585+
updates["oncall_service"] = (
586+
f"{signal.oncall_service.name} -> {oncall_service.name if oncall_service else 'None'}"
587+
)
586588
signal.oncall_service = oncall_service
587589

588590
if signal_in.case_priority:
@@ -592,15 +594,19 @@ def update(
592594
case_priority_in=signal_in.case_priority,
593595
)
594596
if signal.case_priority != case_priority:
595-
updates["case_priority"] = f"{signal.case_priority.name} -> {case_priority.name}"
597+
updates["case_priority"] = (
598+
f"{signal.case_priority.name} -> {case_priority.name if case_priority else 'None'}"
599+
)
596600
signal.case_priority = case_priority
597601

598602
if signal_in.case_type:
599603
case_type = case_type_service.get_by_name_or_default(
600604
db_session=db_session, project_id=signal.project.id, case_type_in=signal_in.case_type
601605
)
602606
if signal.case_type != case_type:
603-
updates["case_type"] = f"{signal.case_type.name} -> {case_type.name}"
607+
updates["case_type"] = (
608+
f"{signal.case_type.name} -> {case_type.name if case_type else 'None'}"
609+
)
604610
signal.case_type = case_type
605611

606612
db_session.commit()
@@ -971,7 +977,12 @@ def get_cases_for_signal_by_resolution_reason(
971977

972978

973979
def get_signal_stats(
974-
*, db_session: Session, entity_value: str, entity_type_id: int, signal_id: int | None = None, num_days: int | None = None
980+
*,
981+
db_session: Session,
982+
entity_value: str,
983+
entity_type_id: int,
984+
signal_id: int | None = None,
985+
num_days: int | None = None,
975986
) -> Optional[SignalStats]:
976987
"""
977988
Gets signal statistics for a given named entity and type.

0 commit comments

Comments
 (0)