Skip to content

Commit 06e357c

Browse files
sullisbrharrington
andauthored
ci: jdk 17 (#473)
Update spotbugs to version that is compatible with jdk17. --------- Co-authored-by: Brian Harrington <[email protected]>
1 parent 372fecd commit 06e357c

File tree

3 files changed

+5
-32
lines changed

3 files changed

+5
-32
lines changed

.github/workflows/pr.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
runs-on: ubuntu-latest
88
strategy:
99
matrix:
10-
java: [8, 11, 15]
10+
java: [8, 11, 17]
1111
steps:
1212
- uses: actions/checkout@v3
1313
with:

build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ subprojects {
9292
}
9393

9494
spotbugs {
95-
toolVersion = '4.2.0'
95+
toolVersion = '4.7.3'
9696
excludeFilter = rootProject.file('codequality/findbugs-exclude.xml')
9797
ignoreFailures = false
9898
spotbugsMain.enabled = true

codequality/findbugs-exclude.xml

+3-30
Original file line numberDiff line numberDiff line change
@@ -7,40 +7,13 @@
77
</And>
88
</Match>
99
<Match>
10-
<And>
11-
<Class name="com.netflix.spectator.sandbox.HttpResponse"/>
12-
<Bug pattern="EI_EXPOSE_REP"/>
13-
</And>
14-
</Match>
15-
<Match>
16-
<And>
17-
<Class name="com.netflix.spectator.sandbox.HttpResponse"/>
18-
<Bug pattern="EI_EXPOSE_REP2"/>
19-
</And>
20-
</Match>
21-
<Match>
22-
<And>
23-
<Class name="com.netflix.spectator.sandbox.HttpRequestBuilder"/>
24-
<Bug pattern="EI_EXPOSE_REP2"/>
25-
</And>
10+
<Bug pattern="EI_EXPOSE_REP"/>
2611
</Match>
2712
<Match>
28-
<And>
29-
<Class name="com.netflix.spectator.ipc.http.HttpResponse"/>
30-
<Bug pattern="EI_EXPOSE_REP"/>
31-
</And>
13+
<Bug pattern="EI_EXPOSE_REP2"/>
3214
</Match>
3315
<Match>
34-
<And>
35-
<Class name="com.netflix.spectator.ipc.http.HttpResponse"/>
36-
<Bug pattern="EI_EXPOSE_REP2"/>
37-
</And>
38-
</Match>
39-
<Match>
40-
<And>
41-
<Class name="com.netflix.spectator.ipc.http.HttpRequestBuilder"/>
42-
<Bug pattern="EI_EXPOSE_REP2"/>
43-
</And>
16+
<Bug pattern="MS_EXPOSE_REP"/>
4417
</Match>
4518
<Match>
4619
<And>

0 commit comments

Comments
 (0)