Skip to content

Commit 3af1211

Browse files
committed
Fix building official docker image (#1023)
1 parent 977b8fa commit 3af1211

File tree

1 file changed

+9
-12
lines changed

1 file changed

+9
-12
lines changed

.github/workflows/docker-image-build-push.yml

+9-12
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@ jobs:
2727

2828
- name: Set up Docker Buildx
2929
uses: docker/setup-buildx-action@v2
30-
30+
3131
- name: Login to Docker Hub
3232
uses: docker/login-action@v2
3333
with:
3434
username: ${{ secrets.DOCKER_USERNAME }}
3535
password: ${{ secrets.DOCKER_PASSWORD }}
36-
36+
3737
- name: Build and push
3838
uses: docker/build-push-action@v4
3939
with:
@@ -59,14 +59,14 @@ jobs:
5959
with:
6060
username: ${{ secrets.DOCKER_USERNAME }}
6161
password: ${{ secrets.DOCKER_PASSWORD }}
62-
62+
6363
- name: Build and push ARM
6464
uses: docker/build-push-action@v4
6565
with:
6666
context: .
6767
platforms: 'linux/arm64'
6868
push: true
69-
tags: nethermindeth/juno:${{ github.event.inputs.tag }}-arm
69+
tags: nethermindeth/juno:${{ github.event.inputs.tag }}-arm64
7070

7171
- name: Cleanup self-hosted
7272
run: |
@@ -86,15 +86,12 @@ jobs:
8686
username: ${{ secrets.DOCKER_USERNAME }}
8787
password: ${{ secrets.DOCKER_PASSWORD }}
8888

89-
- name: Create and push manifest
89+
- name: Create and push manifest using buildx
9090
run: |
91-
export DOCKER_CLI_EXPERIMENTAL=enabled
92-
docker manifest create nethermind/juno:${{ github.event.inputs.tag }} \
93-
nethermindeth/juno:${{ github.event.inputs.tag }} \
94-
nethermindeth/juno:${{ github.event.inputs.tag }}-arm
95-
docker manifest annotate nethermind/juno:${{ github.event.inputs.tag }} nethermindeth/juno:${{ github.event.inputs.tag }}-arm --os linux --arch arm64
96-
docker manifest push nethermind/juno:${{ github.event.inputs.tag }}
97-
91+
docker buildx imagetools create nethermindeth/juno:${{ github.event.inputs.tag }} \
92+
nethermindeth/juno:${{ github.event.inputs.tag }}-arm64 \
93+
--tag nethermind/juno:${{ github.event.inputs.tag }}
94+
9895
- name: Clean up environment
9996
if: always()
10097
run: |

0 commit comments

Comments
 (0)