Ignore or add digits to block version string as neccessary (#739)

to account for non-sem-ver complaint starknet versions

Author: omerfirmak

blockchain/blockchain.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"encoding/binary"
 	"errors"
+	"strings"
 
 	"github.com/Masterminds/semver/v3"
 	"github.com/NethermindEth/juno/core"
@@ -41,7 +42,13 @@ func checkBlockVersion(protocolVersion string) error {
 		return nil
 	}
 
-	blockVer, err := semver.NewVersion(protocolVersion)
+	sep := "."
+	digits := strings.Split(protocolVersion, sep)
+	// pad with 3 zeros in case version has less than 3 digits
+	digits = append(digits, []string{"0", "0", "0"}...)
+
+	// get first 3 digits only
+	blockVer, err := semver.NewVersion(strings.Join(digits[:3], sep))
 	if err != nil {
 		return err
 	}

blockchain/blockchain_test.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"testing"
 
-	"github.com/Masterminds/semver/v3"
 	"github.com/NethermindEth/juno/blockchain"
 	"github.com/NethermindEth/juno/clients/feeder"
 	"github.com/NethermindEth/juno/core"
@@ -141,10 +140,19 @@ func TestVerifyBlock(t *testing.T) {
 		require.Error(t, chain.Store(mainnetBlock0, mainnetStateUpdate0, nil))
 	})
 
-	t.Run("error if version is unsupported", func(t *testing.T) {
+	t.Run("needs padding", func(t *testing.T) {
+		mainnetBlock0.ProtocolVersion = "99.0" // should be padded to "99.0.0"
+		require.EqualError(t, chain.Store(mainnetBlock0, mainnetStateUpdate0, nil), "unsupported block version")
+	})
+
+	t.Run("needs truncating", func(t *testing.T) {
+		mainnetBlock0.ProtocolVersion = "99.0.0.0" // last 0 digit should be ignored
+		require.EqualError(t, chain.Store(mainnetBlock0, mainnetStateUpdate0, nil), "unsupported block version")
+	})
+
+	t.Run("greater than supportedStarknetVersion", func(t *testing.T) {
 		mainnetBlock0.ProtocolVersion = "99.0.0"
-		semver.MustParse(mainnetBlock0.ProtocolVersion)
-		require.Error(t, chain.Store(mainnetBlock0, mainnetStateUpdate0, nil))
+		require.EqualError(t, chain.Store(mainnetBlock0, mainnetStateUpdate0, nil), "unsupported block version")
 	})
 
 	t.Run("no error with no version string", func(t *testing.T) {