Skip to content

Commit b0394f8

Browse files
committed
Keep old behaviour
1 parent 5e2f6ce commit b0394f8

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

l1/eth_subscriber.go

+6-4
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@ package l1
22

33
import (
44
"context"
5+
"errors"
56
"fmt"
67
"math/big"
78
"time"
89

910
"github.com/NethermindEth/juno/l1/contract"
11+
"github.com/ethereum/go-ethereum"
1012
"github.com/ethereum/go-ethereum/accounts/abi/bind"
1113
"github.com/ethereum/go-ethereum/common"
1214
"github.com/ethereum/go-ethereum/core/types"
@@ -66,14 +68,14 @@ func (s *EthSubscriber) FinalisedHeight(ctx context.Context) (uint64, error) {
6668
reqTimer := time.Now()
6769
head, err := s.ethClient.HeaderByNumber(ctx, finalizedBlockNumber)
6870
if err != nil {
71+
if errors.Is(err, ethereum.NotFound) {
72+
s.listener.OnL1Call("eth_getBlockByNumber", time.Since(reqTimer))
73+
return 0, fmt.Errorf("finalised block not found")
74+
}
6975
return 0, fmt.Errorf("get finalised Ethereum block: %w", err)
7076
}
7177
s.listener.OnL1Call("eth_getBlockByNumber", time.Since(reqTimer))
7278

73-
if head == nil {
74-
return 0, fmt.Errorf("finalised block not found")
75-
}
76-
7779
return head.Number.Uint64(), nil
7880
}
7981

0 commit comments

Comments
 (0)