fix: misuse of jsonrpc.Err(...) (#3365)

* fix: misuse of jsonrpc.Err(...)

* update error messages

* add ':' to error message

Author: EgeCaner

rpc/v8/l1.go

@@ -65,7 +65,13 @@ func (h *Handler) GetMessageStatus(ctx context.Context, l1TxnHash *common.Hash)
 	for i, msgHash := range msgHashes {
 		hash, err := h.bcReader.L1HandlerTxnHash(msgHash)
 		if err != nil {
-			return nil, jsonrpc.Err(jsonrpc.InternalError, fmt.Errorf("failed to retrieve L1 handler txn %v", err))
+			return nil, jsonrpc.Err(
+				jsonrpc.InternalError,
+				fmt.Sprintf("failed to retrieve L1 handler txn hash. msgHash %s, err: %v",
+					msgHash.Hex(),
+					err,
+				),
+			)
 		}
 		status, rpcErr := h.TransactionStatus(ctx, hash)
 		if rpcErr != nil {
@@ -91,14 +97,21 @@ func (h *Handler) messageToL2Logs(ctx context.Context, txHash *common.Hash) ([]*
 	}
 
 	messageHashes := make([]*common.Hash, 0, len(receipt.Logs))
-	for _, vLog := range receipt.Logs {
+	for i, vLog := range receipt.Logs {
 		if common.HexToHash(vLog.Topics[0].Hex()).Cmp(logMsgToL2SigHash) != 0 {
 			continue
 		}
 		var event logMessageToL2
 		err = h.coreContractABI.UnpackIntoInterface(&event, "LogMessageToL2", vLog.Data)
 		if err != nil {
-			return nil, jsonrpc.Err(rpccore.ErrInternal.Code, fmt.Errorf("failed to unpack log %v", err))
+			return nil, jsonrpc.Err(
+				jsonrpc.InternalError,
+				fmt.Sprintf("failed to unpack log, l1 txn hash %s, logIndex %d err: %v",
+					txHash.Hex(),
+					i,
+					err,
+				),
+			)
 		}
 		// Extract indexed fields from topics
 		fromAddress := common.HexToAddress(vLog.Topics[1].Hex())

rpc/v9/l1.go

@@ -66,7 +66,13 @@ func (h *Handler) GetMessageStatus(ctx context.Context, l1TxnHash *common.Hash)
 	for i, msgHash := range msgHashes {
 		hash, err := h.bcReader.L1HandlerTxnHash(msgHash)
 		if err != nil {
-			return nil, jsonrpc.Err(jsonrpc.InternalError, fmt.Errorf("failed to retrieve L1 handler txn %v", err))
+			return nil, jsonrpc.Err(
+				jsonrpc.InternalError,
+				fmt.Sprintf("failed to retrieve L1 handler txn hash. msgHash %s, err: %v",
+					msgHash.Hex(),
+					err,
+				),
+			)
 		}
 		status, rpcErr := h.TransactionStatus(ctx, &hash)
 		if rpcErr != nil {
@@ -100,14 +106,21 @@ func (h *Handler) messageToL2Logs(ctx context.Context, txHash *common.Hash) ([]*
 	}
 
 	messageHashes := make([]*common.Hash, 0, len(receipt.Logs))
-	for _, vLog := range receipt.Logs {
+	for i, vLog := range receipt.Logs {
 		if common.HexToHash(vLog.Topics[0].Hex()).Cmp(logMsgToL2SigHash) != 0 {
 			continue
 		}
 		var event logMessageToL2
 		err = h.coreContractABI.UnpackIntoInterface(&event, "LogMessageToL2", vLog.Data)
 		if err != nil {
-			return nil, jsonrpc.Err(rpccore.ErrInternal.Code, fmt.Errorf("failed to unpack log %v", err))
+			return nil, jsonrpc.Err(
+				jsonrpc.InternalError,
+				fmt.Sprintf("failed to unpack log, l1 txn hash %s, logIndex %d err: %v",
+					txHash.Hex(),
+					i,
+					err,
+				),
+			)
 		}
 		// Extract indexed fields from topics
 		fromAddress := common.HexToAddress(vLog.Topics[1].Hex())