Skip to content

Commit f4d9d69

Browse files
authored
Add missing gomock.Controller.Finish() calls in plugin tests (#2225)
1 parent f5dc02c commit f4d9d69

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

plugin/service_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import (
1414
func TestService(t *testing.T) {
1515
t.Run("shutdown ok", func(t *testing.T) {
1616
ctrl := gomock.NewController(t)
17+
defer ctrl.Finish()
1718

1819
p := mocks.NewMockJunoPlugin(ctrl)
1920
p.EXPECT().Shutdown().Return(nil)
@@ -28,6 +29,7 @@ func TestService(t *testing.T) {
2829
})
2930
t.Run("shutdown with error", func(t *testing.T) {
3031
ctrl := gomock.NewController(t)
32+
defer ctrl.Finish()
3133

3234
shutdownErr := errors.New("error during shutdown")
3335

0 commit comments

Comments
 (0)