Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unix socket support #1277

Open
Exca-DK opened this issue Sep 26, 2023 · 2 comments · May be fixed by #1362
Open

Unix socket support #1277

Exca-DK opened this issue Sep 26, 2023 · 2 comments · May be fixed by #1362
Assignees
Labels
no-stale RPC JSON RPC API

Comments

@Exca-DK
Copy link
Contributor

Exca-DK commented Sep 26, 2023

Issue

Currently, jsonrpc only supports http and ws.

Rationale

Why should this feature exist?
Unix socket support would enhance the project by providing a more secure and efficient communication mechanism. Unix sockets typically have lower latency and higher throughput than TCP. This feature is particularly useful when hosting multiple users on the same machine since access can be easly restricted.

Implementation

Do you have ideas regarding the implementation of this feature? yes
Are you willing to implement this feature? yes

Scope:

  • Implementing unix handler.

  • Adding cli-flags (unix-enabled and unix-path ).

Additional Information:

Windows would require downloading another package.

@joshklop joshklop added the RPC JSON RPC API label Sep 26, 2023
@stranger80 stranger80 moved this from Todo to Backlog in [Nubia] Juno Oct 5, 2023
@joshklop
Copy link
Contributor

Some notes:

Windows would require downloading another package.

We can skip Windows support for now. We only test on Linux and MacOS.

Adding cli-flags (unix-enabled and unix-path).

Can we use ipc (similar to our http and ws flags) and ipc-path? This gives us the option to add Windows support later without changing the name of the flag.

@Exca-DK
Copy link
Contributor Author

Exca-DK commented Oct 18, 2023

Sure, I will start working on that.

@Exca-DK Exca-DK linked a pull request Oct 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-stale RPC JSON RPC API
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants