Fix state test runner not handling invalid tx properly (#7909)

Author: smartprogrammer93

src/Nethermind/Ethereum.Test.Base/GeneralTestBase.cs

@@ -133,31 +133,37 @@ protected EthereumTestResult RunTest(GeneralStateTest test, ITxTracer txTracer)
             }
 
             ValidationResult txIsValid = _txValidator.IsWellFormed(test.Transaction, spec);
-
+            TransactionResult? txResult = null;
             if (txIsValid)
             {
-                transactionProcessor.Execute(test.Transaction, new BlockExecutionContext(header), txTracer);
+                txResult = transactionProcessor.Execute(test.Transaction, new BlockExecutionContext(header), txTracer);
             }
             else
             {
                 _logger.Info($"Skipping invalid tx with error: {txIsValid.Error}");
             }
 
             stopwatch.Stop();
+            if (txResult is not null && txResult.Value == TransactionResult.Ok)
+            {
+                stateProvider.Commit(specProvider.GetSpec((ForkActivation)1));
+                stateProvider.CommitTree(1);
+
+                // '@winsvega added a 0-wei reward to the miner , so we had to add that into the state test execution phase. He needed it for retesteth.'
+                if (!stateProvider.AccountExists(test.CurrentCoinbase))
+                {
+                    stateProvider.CreateAccount(test.CurrentCoinbase, 0);
+                }
 
-            stateProvider.Commit(specProvider.GetSpec((ForkActivation)1));
-            stateProvider.CommitTree(1);
+                stateProvider.Commit(specProvider.GetSpec((ForkActivation)1));
 
-            // '@winsvega added a 0-wei reward to the miner , so we had to add that into the state test execution phase. He needed it for retesteth.'
-            if (!stateProvider.AccountExists(test.CurrentCoinbase))
+                stateProvider.RecalculateStateRoot();
+            }
+            else
             {
-                stateProvider.CreateAccount(test.CurrentCoinbase, 0);
+                stateProvider.Reset();
             }
 
-            stateProvider.Commit(specProvider.GetSpec((ForkActivation)1));
-
-            stateProvider.RecalculateStateRoot();
-
             List<string> differences = RunAssertions(test, stateProvider);
             EthereumTestResult testResult = new(test.Name, test.ForkName, differences.Count == 0);
             testResult.TimeInMs = stopwatch.Elapsed.TotalMilliseconds;