Fix Network.DiagTracerEnabled object disposed (#6912)

Co-authored-by: Lukasz Rozmej <[email protected]>

Author: 2 people

src/Nethermind/Nethermind.Network/P2P/ProtocolHandlers/P2PProtocolHandler.cs

@@ -303,9 +303,10 @@ public override void DisconnectProtocol(DisconnectReason disconnectReason, strin
         if (Logger.IsTrace)
             Logger.Trace($"Sending disconnect {disconnectReason} ({details}) to {Session.Node:s}");
         DisconnectMessage message = new(disconnectReason.ToEthDisconnectReason());
-        Send(message);
         if (NetworkDiagTracer.IsEnabled)
             NetworkDiagTracer.ReportDisconnect(Session.Node.Address, $"Local {disconnectReason} {details}");
+        Send(message);
+
     }
 
     private void SendHello()

src/Nethermind/Nethermind.Network/P2P/ProtocolHandlers/ProtocolHandlerBase.cs

@@ -81,8 +81,14 @@ protected internal void Send<T>(T message) where T : P2PMessage
         {
             Interlocked.Increment(ref Counter);
             if (Logger.IsTrace) Logger.Trace($"{Counter} Sending {typeof(T).Name}");
-            int size = Session.DeliverMessage(message);
-            if (NetworkDiagTracer.IsEnabled) NetworkDiagTracer.ReportOutgoingMessage(Session.Node?.Address, Name, message.ToString(), size);
+            if (NetworkDiagTracer.IsEnabled)
+            {
+                string messageString = message.ToString();
+                int size = Session.DeliverMessage(message);
+                NetworkDiagTracer.ReportOutgoingMessage(Session.Node?.Address, Name, messageString, size);
+            }
+            else
+                Session.DeliverMessage(message);
         }
 
         protected async Task CheckProtocolInitTimeout()