eip 7840 implementation #7964
Open
eip 7840 implementation #7964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartprogrammer93
requested changes
Dec 23, 2024
# Conflicts: # src/Nethermind/Nethermind.Specs/ChainSpecStyle/ChainParameters.cs
MarekM25
reviewed
Jan 6, 2025
src/Nethermind/Nethermind.Specs/ChainSpecStyle/ChainSpecBasedSpecProvider.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Specs/ChainSpecStyle/ChainSpecLoader.cs
Outdated
Show resolved
Hide resolved
tanishqjasoria
requested changes
Jan 7, 2025
src/Nethermind/Nethermind.Blockchain.Test/TransactionSelectorTests.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Blockchain.Test/TransactionSelectorTests.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Blockchain.Test/Validators/TxValidatorTests.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Blockchain.Test/Validators/ShardBlobBlockValidatorTests.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Blockchain.Test/Validators/TxValidatorTests.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm.Test/TransactionProcessorEip4844Tests.cs
Outdated
Show resolved
Hide resolved
yerke26
commented
Jan 8, 2025
src/Nethermind/Nethermind.JsonRpc.Test/Modules/Eth/EthRpcModuleTests.FeeHistory.cs
Outdated
Show resolved
Hide resolved
yerke26
commented
Jan 8, 2025
src/Nethermind/Nethermind.JsonRpc.Test/Modules/Eth/EthRpcModuleTests.cs
Outdated
Show resolved
Hide resolved
| @@ -20,7 +20,7 @@ public class PooledTxsRequestor(ITxPool txPool, ITxPoolConfig txPoolConfig) : IP | |||
| private readonly long _configuredMaxTxSize = txPoolConfig.MaxTxSize ?? long.MaxValue; | |||
|
|
|||
| private readonly long _configuredMaxBlobTxSize = txPoolConfig.MaxBlobTxSize is not null | |||
| ? txPoolConfig.MaxBlobTxSize.Value + (long)Eip4844Constants.MaxBlobGasPerBlock : long.MaxValue; | |||
| ? txPoolConfig.MaxBlobTxSize.Value + (long)Eip4844Constants.GasPerBlob * 6 : long.MaxValue; // ToDo Yerken * 6 is incorrect here, quick fix to compile the project | |||
There was a problem hiding this comment.
this needs to be addressed, but how?
| @@ -282,10 +283,10 @@ public async Task SendData( | |||
|
|
|||
| if (defaultMaxFeePerBlobGas is null) | |||
| { | |||
| ulong excessBlobsReserve = 2 * Eip4844Constants.TargetBlobGasPerBlock; | |||
| ulong excessBlobsReserve = 2 * Cancun.Instance.TargetBlobCount; | |||
There was a problem hiding this comment.
we might need to change this
There was a problem hiding this comment.
maybe we add spec as command line param to this tool
smartprogrammer93
approved these changes
Jan 8, 2025
src/Nethermind/Nethermind.Network/P2P/Subprotocols/Eth/PooledTxsRequestor.cs
Outdated
Show resolved
Hide resolved
yerke26
commented
Jan 9, 2025
Comment on lines
+265
to
+266
| spec.TargetBlobCount = 3; | ||
| spec.MaxBlobCount = 6; |
There was a problem hiding this comment.
I think they should be zero as written here
There was a problem hiding this comment.
yes, according to the EIP it should be zero
There was a problem hiding this comment.
changed back to zero
There was a problem hiding this comment.
@MarekM25 did this i think to fix hive tests. For hive, i think we should specifiy them in its chainspec
src/Nethermind/Nethermind.Network/P2P/Subprotocols/Eth/PooledTxsRequestor.cs
Outdated
Show resolved
Hide resolved
MarekM25
reviewed
Jan 10, 2025
src/Nethermind/Chains/gnosis.json
Outdated
| @@ -97,7 +97,8 @@ | |||
| "cancun": { | |||
| "target": 1, | |||
| "max": 2 | |||
| } | |||
| }, | |||
| "eip7840DefaultBlobCountFraction": 3 | |||
There was a problem hiding this comment.
do we really need this variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9129
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.