Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttling should only be activated in the case of too many pending requests #62

Open
skrawcz opened this issue Jul 8, 2015 · 1 comment

Comments

@skrawcz
Copy link

skrawcz commented Jul 8, 2015

The current throttling mechanism is primitive; it artificially limits throughput even though ZK might be perfectly find to handle and respond to the requests.

E.g. default throttling setting is 50 calls in 2 seconds. You could easily construct the scenario where ZK returns all the calls in 1 second, and that means any subsequent calls will sleep for 1 second before hitting ZK, even though ZK is idle.

A better solution that would work without having to fine tune the throttling setting, would be to throttle when the number of pending requests is growing faster than they can be served by ZK.

@diranged
Copy link
Contributor

@skrawcz, I completely agree that the throttling mechanism is primitive. I'm not sure how to implement your suggestion -- do you think you could hack something up to see?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants