Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the performance of the Watcher.get() method. #63

Open
diranged opened this issue Jul 10, 2015 · 0 comments
Open

Improve the performance of the Watcher.get() method. #63

diranged opened this issue Jul 10, 2015 · 0 comments
Assignees
Milestone

Comments

@diranged
Copy link
Contributor

Currently the Watcher.get() method generates a fresh dict {} and populates it before returning it to the caller. This is fine, but not fast -- calling this over and over again is slow, especially if you have a large payload. We should do this once during the Watcher._update() method call, and be done.

https://github.com/Nextdoor/ndserviceregistry/blob/master/nd_service_registry/watcher.py#L117-L124

CC: @skrawcz

@diranged diranged self-assigned this Jul 10, 2015
@diranged diranged added this to the v1.0.1 milestone Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant