Skip to content

Commit d8de84e

Browse files
authored
Merge pull request #109 from Nexters/dev
Dev
2 parents 0cbe71e + 3f586fe commit d8de84e

File tree

4 files changed

+8
-1
lines changed

4 files changed

+8
-1
lines changed

src/main/java/donmani/donmani_server/expense/dto/ExpenseResponseDTO.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,5 @@ public class ExpenseResponseDTO {
1919
private List<RecordDTO> records;
2020
private List<RewardItemResponseDTO> saveItems;
2121
private boolean hasNotOpenedRewards;
22+
private Integer totalExpensesCount;
2223
}

src/main/java/donmani/donmani_server/expense/service/ExpenseService.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,12 +95,16 @@ public ExpenseResponseDTO getExpenses(String userKey, int year, int month, boole
9595
// 오픈하지 않은 선물 여부 확인
9696
boolean hasNotOpenedRewards = rewardService.hasNotOpenedRewards(userKey);
9797

98+
// 현재 기록 개수 확인
99+
Integer totalExpensesCount = getTotalExpensesCount(userKey);
100+
98101
if(expenses.isEmpty()) {
99102
return ExpenseResponseDTO.builder()
100103
.userKey(userKey)
101104
.records(null)
102105
.saveItems(rewardService.getSavedItem(userKey, year, month))
103106
.hasNotOpenedRewards(hasNotOpenedRewards)
107+
.totalExpensesCount(totalExpensesCount)
104108
.build();
105109
}
106110

@@ -109,6 +113,7 @@ public ExpenseResponseDTO getExpenses(String userKey, int year, int month, boole
109113
.records(expenseToDto(expenses, sortedDesc))
110114
.saveItems(rewardService.getSavedItem(userKey, year, month))
111115
.hasNotOpenedRewards(hasNotOpenedRewards)
116+
.totalExpensesCount(totalExpensesCount)
112117
.build();
113118
}
114119

src/main/java/donmani/donmani_server/feedback/service/FeedbackService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public Boolean isNotOpenedFeedback(String userKey) {
8888
}
8989

9090
// 3. 이미 12개를 모두 열었다면 isNotOpened를 false로
91-
List<UserItem> acquiredItems = userItemRepository.findAllByUser(user);
91+
List<UserItem> acquiredItems = userItemRepository.findByUserOrderByAcquiredAtDesc(user);
9292

9393
if(acquiredItems.size() == 12) {
9494
return false;

src/main/java/donmani/donmani_server/reward/repository/UserItemRepository.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
public interface UserItemRepository extends JpaRepository<UserItem, Long> {
1414
@Query("SELECT ui FROM UserItem ui " +
1515
"WHERE ui.user = :user " +
16+
"AND ui.isOpened = true " +
1617
"ORDER BY ui.acquiredAt DESC")
1718
List<UserItem> findByUserOrderByAcquiredAtDesc(
1819
@Param("user") User user

0 commit comments

Comments
 (0)