Maintenance: Notification Service - Improve performance and code consistency (#102)

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Claude <[email protected]>

Author: 3 people

src/main/java/spring/memewikibe/application/notification/MemeNotificationService.java

@@ -4,7 +4,6 @@
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Service;
 import spring.memewikibe.domain.meme.Meme;
-import spring.memewikibe.domain.notification.NotificationToken;
 import spring.memewikibe.infrastructure.MemeRepository;
 import spring.memewikibe.infrastructure.NotificationTokenRepository;
 import spring.memewikibe.support.error.ErrorType;
@@ -26,10 +25,7 @@ public void sendMemeNotification(Long memeId, String title, String body) {
         Meme meme = memeRepository.findById(memeId)
             .orElseThrow(() -> new MemeWikiApplicationException(ErrorType.MEME_NOT_FOUND));
 
-        List<String> tokens = tokenRepository.findAll()
-            .stream()
-            .map(NotificationToken::getToken)
-            .toList();
+        List<String> tokens = tokenRepository.findAllTokens();
 
         if (tokens.isEmpty()) {
             log.info("No active tokens found for meme notification: memeId={}", memeId);

src/main/java/spring/memewikibe/application/notification/NotificationTokenRegister.java

@@ -1,18 +1,17 @@
 package spring.memewikibe.application.notification;
 
+import lombok.RequiredArgsConstructor;
 import org.springframework.lang.NonNull;
 import org.springframework.stereotype.Component;
 import org.springframework.transaction.annotation.Transactional;
 import spring.memewikibe.domain.notification.NotificationToken;
 import spring.memewikibe.infrastructure.NotificationTokenRepository;
 
 @Component
+@RequiredArgsConstructor
 public class NotificationTokenRegister {
-    private final NotificationTokenRepository notificationTokenRepository;
 
-    public NotificationTokenRegister(NotificationTokenRepository notificationTokenRepository) {
-        this.notificationTokenRepository = notificationTokenRepository;
-    }
+    private final NotificationTokenRepository notificationTokenRepository;
 
     @Transactional
     public void registerToken(@NonNull final String token) {

src/main/java/spring/memewikibe/infrastructure/NotificationTokenRepository.java

@@ -1,7 +1,13 @@
 package spring.memewikibe.infrastructure;
 
 import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.data.jpa.repository.Query;
 import spring.memewikibe.domain.notification.NotificationToken;
 
+import java.util.List;
+
 public interface NotificationTokenRepository extends JpaRepository<NotificationToken, String> {
+
+    @Query("SELECT n.token FROM NotificationToken n")
+    List<String> findAllTokens();
 }

src/test/java/spring/memewikibe/infrastructure/NotificationTokenRepositoryTest.java

@@ -28,5 +28,20 @@ class NotificationTokenRepositoryTest {
         then(saved.getCreatedAt()).isNotNull();
         then(saved.getUpdatedAt()).isNotNull();
     }
+
+    @Test
+    void 모든_토큰_문자열을_조회할_수_있다() {
+        // given
+        sut.save(NotificationToken.create("token1"));
+        sut.save(NotificationToken.create("token2"));
+        sut.save(NotificationToken.create("token3"));
+        sut.flush();
+
+        // when
+        var tokens = sut.findAllTokens();
+
+        // then
+        then(tokens).containsExactlyInAnyOrder("token1", "token2", "token3");
+    }
 }