Skip to content

Commit 793dee6

Browse files
claude[bot]github-actions[bot]claude
authored
Maintenance: MemeCreateService - Improve code quality and readability (#96)
Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Claude <[email protected]>
1 parent 8547027 commit 793dee6

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/main/java/spring/memewikibe/application/MemeCreateService.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,18 +55,22 @@ public long createMeme(MemeCreateRequest request, MultipartFile imageFile) {
5555
.ifPresent(memeCategoryRepository::saveAll);
5656

5757
log.info("밈 생성 완료: {}", savedMeme.getId());
58+
registerPostCommitIndexing(savedMeme);
59+
return savedMeme.getId();
60+
}
61+
62+
private void registerPostCommitIndexing(Meme meme) {
5863
org.springframework.transaction.support.TransactionSynchronizationManager.registerSynchronization(
5964
new org.springframework.transaction.support.TransactionSynchronization() {
6065
@Override
6166
public void afterCommit() {
6267
try {
63-
vectorIndexService.index(savedMeme);
68+
vectorIndexService.index(meme);
6469
} catch (Exception e) {
65-
log.warn("[afterCommit] Failed to index meme {} to Pinecone: {}", savedMeme.getId(), e.toString());
70+
log.warn("[afterCommit] Failed to index meme {} to Pinecone: {}", meme.getId(), e.toString());
6671
}
6772
}
6873
}
6974
);
70-
return savedMeme.getId();
7175
}
7276
}

src/test/java/spring/memewikibe/application/MemeCreateServiceTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import org.junit.jupiter.api.AfterEach;
44
import org.junit.jupiter.api.DisplayName;
55
import org.junit.jupiter.api.Test;
6-
import org.mockito.Mockito;
76
import org.springframework.beans.factory.annotation.Autowired;
87
import org.springframework.test.context.bean.override.mockito.MockitoBean;
98
import org.springframework.web.multipart.MultipartFile;

0 commit comments

Comments
 (0)