Skip to content

Commit d35988e

Browse files
claude[bot]github-actions[bot]claude
authored
Maintenance: Response & Error classes - Modernize with Java 21 and improve code consistency (#112)
Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Claude <[email protected]>
1 parent 2d94489 commit d35988e

File tree

3 files changed

+11
-23
lines changed

3 files changed

+11
-23
lines changed
Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,15 @@
11
package spring.memewikibe.support.error;
22

3-
import lombok.Getter;
4-
5-
@Getter
6-
public final class ErrorMessage {
7-
private final String code;
8-
private final String message;
9-
private final Object data;
10-
3+
public record ErrorMessage(
4+
String code,
5+
String message,
6+
Object data
7+
) {
118
public ErrorMessage(ErrorType errorType) {
12-
this.code = errorType.getCode().name();
13-
this.message = errorType.getMessage();
14-
this.data = null;
9+
this(errorType.getCode().name(), errorType.getMessage(), null);
1510
}
1611

1712
public ErrorMessage(ErrorType errorType, Object data) {
18-
this.code = errorType.getCode().name();
19-
this.message = errorType.getMessage();
20-
this.data = data;
13+
this(errorType.getCode().name(), errorType.getMessage(), data);
2114
}
2215
}

src/main/java/spring/memewikibe/support/response/ApiResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public final class ApiResponse<S> {
1010
private final S success;
1111
private final ErrorMessage error;
1212

13-
public ApiResponse(ResultType resultType, S success, ErrorMessage error) {
13+
private ApiResponse(ResultType resultType, S success, ErrorMessage error) {
1414
this.resultType = resultType;
1515
this.success = success;
1616
this.error = error;
Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
package spring.memewikibe.support.response;
22

3+
import lombok.Getter;
4+
35
import java.util.List;
46

7+
@Getter
58
public class PageResponse<P extends Paging, T> {
69
private final P paging;
710
private final List<T> results;
@@ -14,12 +17,4 @@ private PageResponse(P paging, List<T> results) {
1417
public static <T> PageResponse<Cursor, T> cursor(Cursor paging, List<T> results) {
1518
return new PageResponse<>(paging, results.subList(0, Math.min(results.size(), paging.getPageSize())));
1619
}
17-
18-
public P getPaging() {
19-
return paging;
20-
}
21-
22-
public List<T> getResults() {
23-
return results;
24-
}
2520
}

0 commit comments

Comments
 (0)