Skip to content

Commit 6b44130

Browse files
committed
refactor: native handler 빈값 추가
1 parent dea2ba5 commit 6b44130

File tree

6 files changed

+18
-13
lines changed

6 files changed

+18
-13
lines changed

src/components/Home/Home.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ const Home = () => {
2424
<IconButton
2525
text="갤러리"
2626
iconName="gallery"
27-
onClick={() => send({ type: AppBridgeMessageType.OPEN_GALLERY })}
27+
onClick={() => send({ type: AppBridgeMessageType.OPEN_GALLERY, payload: "" })}
2828
/>
2929
<IconButton
3030
text="카메라"
3131
iconName="camera"
32-
onClick={() => send({ type: AppBridgeMessageType.OPEN_CAMERA })}
32+
onClick={() => send({ type: AppBridgeMessageType.OPEN_CAMERA, payload: "" })}
3333
/>
3434
</div>
3535
</div>

src/components/RecognitionFail/RecognitionFail.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const RecognitionFail = () => {
2929
<Button
3030
text="다시 촬영하기"
3131
variant="secondary"
32-
onClick={() => send({ type: AppBridgeMessageType.OPEN_CAMERA })}
32+
onClick={() => send({ type: AppBridgeMessageType.OPEN_CAMERA, payload: "" })}
3333
/>
3434
</div>
3535
</div>

src/components/provider/AppBridgeProvider/AppBridgeMessage.types.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,17 @@ export type AppBridgeMessage =
1515

1616
export interface OpenCameraMessage {
1717
type: AppBridgeMessageType.OPEN_CAMERA;
18+
payload: "";
1819
}
1920

2021
export interface OpenGalleryMessage {
2122
type: AppBridgeMessageType.OPEN_GALLERY;
23+
payload: "";
2224
}
2325

2426
export interface ShareMessage {
2527
type: AppBridgeMessageType.SHARE;
28+
payload: "";
2629
}
2730

2831
export interface CreateReviewMessage {

src/components/provider/AppBridgeProvider/convertToNativeMessage.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,11 @@ const iosHandlers = {
1313
};
1414

1515
const androidHandlers = {
16-
[AppBridgeMessageType.OPEN_CAMERA]: () => window.AndroidBridge?.openCamera(),
17-
[AppBridgeMessageType.OPEN_GALLERY]: () => window.AndroidBridge?.openGallery(),
18-
[AppBridgeMessageType.SHARE]: () => window.AndroidBridge?.share(),
16+
[AppBridgeMessageType.OPEN_CAMERA]: (message: string) =>
17+
window.AndroidBridge?.openCamera(message),
18+
[AppBridgeMessageType.OPEN_GALLERY]: (message: string) =>
19+
window.AndroidBridge?.openGallery(message),
20+
[AppBridgeMessageType.SHARE]: (message: string) => window.AndroidBridge?.share(message),
1921
[AppBridgeMessageType.CREATE_REVIEW]: (message: { payload: { json: string } }) =>
2022
window.AndroidBridge?.createReview(message.payload.json),
2123
[AppBridgeMessageType.COPY]: (message: { payload: { json: string } }) =>

src/pages/HomePage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const HomePage = () => {
1818
<Navbar.LeftButton onClick={navigateToHome}>
1919
<Icon name="logo" />
2020
</Navbar.LeftButton>
21-
<Navbar.RightButton onClick={() => send({ type: AppBridgeMessageType.SHARE })}>
21+
<Navbar.RightButton onClick={() => send({ type: AppBridgeMessageType.SHARE, payload: "" })}>
2222
<Text variant="bodySm" color="secondary">
2323
앱 공유하기
2424
</Text>

src/types/global.d.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,17 @@ declare global {
1313
interface Window {
1414
webkit?: {
1515
messageHandlers: {
16-
openCamera: MessageHandler;
17-
openGallery: MessageHandler;
18-
share: MessageHandler;
16+
openCamera: MessageHandler<string>;
17+
openGallery: MessageHandler<string>;
18+
share: MessageHandler<string>;
1919
createReview: MessageHandler<string>;
2020
copy: MessageHandler<string>;
2121
};
2222
};
2323
AndroidBridge?: {
24-
openCamera: () => void;
25-
openGallery: () => void;
26-
share: () => void;
24+
openCamera: (request: string) => void;
25+
openGallery: (request: string) => void;
26+
share: (request: string) => void;
2727
createReview: (json: string) => void;
2828
copy: (json: string) => void;
2929
};

0 commit comments

Comments
 (0)