[#10] feat: User 관련 길이 제한을 도메인으로 이동

hyh1016 · hyh1016 · commit 875d31ed8a90 · 2025-08-16T20:57:18.000+09:00
diff --git a/src/main/java/com/nexters/teamace/auth/application/LoginCommand.java b/src/main/java/com/nexters/teamace/auth/application/LoginCommand.java
@@ -2,14 +2,15 @@
 
 import static com.nexters.teamace.common.exception.ValidationErrorMessage.*;
 
+import com.nexters.teamace.user.domain.User;
 import org.springframework.util.StringUtils;
 
 public record LoginCommand(String username) {
     public LoginCommand {
         if (!StringUtils.hasText(username)) {
             throw new IllegalArgumentException(USERNAME_NOT_BLANK);
         }
-        if (username.length() > 20) {
+        if (username.length() > User.MAX_USERNAME_LENGTH) {
             throw new IllegalArgumentException(USERNAME_SIZE);
         }
     }
diff --git a/src/main/java/com/nexters/teamace/auth/application/SignupCommand.java b/src/main/java/com/nexters/teamace/auth/application/SignupCommand.java
@@ -2,20 +2,21 @@
 
 import static com.nexters.teamace.common.exception.ValidationErrorMessage.*;
 
+import com.nexters.teamace.user.domain.User;
 import org.springframework.util.StringUtils;
 
 public record SignupCommand(String username, String nickname) {
     public SignupCommand {
         if (!StringUtils.hasText(username)) {
             throw new IllegalArgumentException(USERNAME_NOT_BLANK);
         }
-        if (username.length() > 20) {
+        if (username.length() > User.MAX_USERNAME_LENGTH) {
             throw new IllegalArgumentException(USERNAME_SIZE);
         }
         if (!StringUtils.hasText(nickname)) {
             throw new IllegalArgumentException(NICKNAME_NOT_BLANK);
         }
-        if (nickname.length() > 20) {
+        if (nickname.length() > User.MAX_NICKNAME_LENGTH) {
             throw new IllegalArgumentException(NICKNAME_SIZE);
         }
     }
diff --git a/src/main/java/com/nexters/teamace/auth/presentation/SignupRequest.java b/src/main/java/com/nexters/teamace/auth/presentation/SignupRequest.java
@@ -1,13 +1,20 @@
 package com.nexters.teamace.auth.presentation;
 
 import com.nexters.teamace.common.exception.ValidationErrorMessage;
+import com.nexters.teamace.user.domain.User;
 import jakarta.validation.constraints.NotBlank;
 import jakarta.validation.constraints.Size;
 
 public record SignupRequest(
         @NotBlank(message = ValidationErrorMessage.USERNAME_NOT_BLANK)
-                @Size(min = 1, max = 20, message = ValidationErrorMessage.USERNAME_SIZE)
+                @Size(
+                        min = 1,
+                        max = User.MAX_USERNAME_LENGTH,
+                        message = ValidationErrorMessage.USERNAME_SIZE)
                 String username,
         @NotBlank(message = ValidationErrorMessage.NICKNAME_NOT_BLANK)
-                @Size(min = 1, max = 20, message = ValidationErrorMessage.NICKNAME_SIZE)
+                @Size(
+                        min = 1,
+                        max = User.MAX_NICKNAME_LENGTH,
+                        message = ValidationErrorMessage.NICKNAME_SIZE)
                 String nickname) {}
diff --git a/src/main/java/com/nexters/teamace/common/exception/ValidationErrorMessage.java b/src/main/java/com/nexters/teamace/common/exception/ValidationErrorMessage.java
@@ -1,5 +1,7 @@
 package com.nexters.teamace.common.exception;
 
+import com.nexters.teamace.user.domain.User;
+
 public class ValidationErrorMessage {
 
     /** Auth */
@@ -9,9 +11,11 @@ public class ValidationErrorMessage {
     public static final String USER_ID_NOT_NULL = "User ID cannot be null";
 
     public static final String USER_ID_POSITIVE = "User ID must be greater than or equal to 1";
-    public static final String USERNAME_SIZE = "Username must be between 1 and 20 characters";
+    public static final String USERNAME_SIZE =
+            "Username must be between 1 and " + User.MAX_USERNAME_LENGTH + " characters";
 
-    public static final String NICKNAME_SIZE = "Nickname must be between 1 and 20 characters";
+    public static final String NICKNAME_SIZE =
+            "Nickname must be between 1 and " + User.MAX_NICKNAME_LENGTH + " characters";
     public static final String USERNAME_NOT_BLANK = "username must not be blank";
     public static final String NICKNAME_NOT_BLANK = "nickname must not be blank";
 
diff --git a/src/main/java/com/nexters/teamace/user/application/CreateUserCommand.java b/src/main/java/com/nexters/teamace/user/application/CreateUserCommand.java
@@ -2,6 +2,7 @@
 
 import static com.nexters.teamace.common.exception.ValidationErrorMessage.*;
 
+import com.nexters.teamace.user.domain.User;
 import org.springframework.util.StringUtils;
 
 public record CreateUserCommand(String username, String nickname) {
@@ -10,15 +11,15 @@ public record CreateUserCommand(String username, String nickname) {
             if (!StringUtils.hasText(username)) {
                 throw new IllegalArgumentException(USERNAME_NOT_BLANK);
             }
-            if (username.length() > 20) {
+            if (username.length() > User.MAX_USERNAME_LENGTH) {
                 throw new IllegalArgumentException(USERNAME_SIZE);
             }
         }
         if (nickname != null) {
             if (!StringUtils.hasText(nickname)) {
                 throw new IllegalArgumentException(NICKNAME_NOT_BLANK);
             }
-            if (nickname.length() > 20) {
+            if (nickname.length() > User.MAX_NICKNAME_LENGTH) {
                 throw new IllegalArgumentException(NICKNAME_SIZE);
             }
         }
diff --git a/src/main/java/com/nexters/teamace/user/domain/User.java b/src/main/java/com/nexters/teamace/user/domain/User.java
@@ -9,6 +9,8 @@
 @NoArgsConstructor(access = PROTECTED)
 @EqualsAndHashCode(onlyExplicitlyIncluded = true)
 public class User {
+    public static final int MAX_USERNAME_LENGTH = 50;
+    public static final int MAX_NICKNAME_LENGTH = 20;
 
     @Getter @EqualsAndHashCode.Include private Long id;
     @Getter private String username;
diff --git a/src/test/java/com/nexters/teamace/auth/application/LoginCommandTest.java b/src/test/java/com/nexters/teamace/auth/application/LoginCommandTest.java
@@ -50,17 +50,17 @@ void it_throws_IllegalArgumentException() {
     }
 
     @Nested
-    @DisplayName("20자보다 긴 사용자명으로 생성할 때")
+    @DisplayName("50자보다 긴 사용자명으로 생성할 때")
     class Context_when_creating_with_username_longer_than_20_characters {
 
         @Test
         @DisplayName("IllegalArgumentException을 던진다")
         void it_throws_IllegalArgumentException() {
-            final String longUsername = "a".repeat(21);
+            final String longUsername = "a".repeat(51);
 
             thenThrownBy(() -> new LoginCommand(longUsername))
                     .isInstanceOf(IllegalArgumentException.class)
-                    .hasMessage("Username must be between 1 and 20 characters");
+                    .hasMessage("Username must be between 1 and 50 characters");
         }
     }
 }
diff --git a/src/test/java/com/nexters/teamace/auth/application/SignupCommandTest.java b/src/test/java/com/nexters/teamace/auth/application/SignupCommandTest.java
@@ -51,17 +51,17 @@ void it_throws_IllegalArgumentException() {
     }
 
     @Nested
-    @DisplayName("20자보다 긴 사용자명으로 생성할 때")
+    @DisplayName("50자보다 긴 사용자명으로 생성할 때")
     class Context_when_creating_with_username_longer_than_20_characters {
 
         @Test
         @DisplayName("IllegalArgumentException을 던진다")
         void it_throws_IllegalArgumentException() {
-            final String longUsername = "a".repeat(21);
+            final String longUsername = "a".repeat(51);
 
             thenThrownBy(() -> new SignupCommand(longUsername, "Valid User"))
                     .isInstanceOf(IllegalArgumentException.class)
-                    .hasMessage("Username must be between 1 and 20 characters");
+                    .hasMessage("Username must be between 1 and 50 characters");
         }
     }
 
diff --git a/src/test/java/com/nexters/teamace/user/application/CreateUserCommandTest.java b/src/test/java/com/nexters/teamace/user/application/CreateUserCommandTest.java
@@ -66,17 +66,17 @@ void it_throws_IllegalArgumentException() {
     }
 
     @Nested
-    @DisplayName("20자보다 긴 사용자명으로 생성할 때")
+    @DisplayName("50자보다 긴 사용자명으로 생성할 때")
     class Context_when_creating_with_username_longer_than_20_characters {
 
         @Test
         @DisplayName("IllegalArgumentException을 던진다")
         void it_throws_IllegalArgumentException() {
-            final String longUsername = "a".repeat(21);
+            final String longUsername = "a".repeat(51);
 
             thenThrownBy(() -> new CreateUserCommand(longUsername, "Valid User"))
                     .isInstanceOf(IllegalArgumentException.class)
-                    .hasMessage("Username must be between 1 and 20 characters");
+                    .hasMessage("Username must be between 1 and 50 characters");
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -2,14 +2,15 @@`
`2`	`2`
`3`	`3`	`import static com.nexters.teamace.common.exception.ValidationErrorMessage.*;`
`4`	`4`
	`5`	`+import com.nexters.teamace.user.domain.User;`
`5`	`6`	`import org.springframework.util.StringUtils;`
`6`	`7`
`7`	`8`	`public record LoginCommand(String username) {`
`8`	`9`	`public LoginCommand {`
`9`	`10`	`if (!StringUtils.hasText(username)) {`
`10`	`11`	`throw new IllegalArgumentException(USERNAME_NOT_BLANK);`
`11`	`12`	`}`
`12`		`- if (username.length() > 20) {`
	`13`	`+ if (username.length() > User.MAX_USERNAME_LENGTH) {`
`13`	`14`	`throw new IllegalArgumentException(USERNAME_SIZE);`
`14`	`15`	`}`
`15`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,20 +2,21 @@`
`2`	`2`
`3`	`3`	`import static com.nexters.teamace.common.exception.ValidationErrorMessage.*;`
`4`	`4`
	`5`	`+import com.nexters.teamace.user.domain.User;`
`5`	`6`	`import org.springframework.util.StringUtils;`
`6`	`7`
`7`	`8`	`public record SignupCommand(String username, String nickname) {`
`8`	`9`	`public SignupCommand {`
`9`	`10`	`if (!StringUtils.hasText(username)) {`
`10`	`11`	`throw new IllegalArgumentException(USERNAME_NOT_BLANK);`
`11`	`12`	`}`
`12`		`- if (username.length() > 20) {`
	`13`	`+ if (username.length() > User.MAX_USERNAME_LENGTH) {`
`13`	`14`	`throw new IllegalArgumentException(USERNAME_SIZE);`
`14`	`15`	`}`
`15`	`16`	`if (!StringUtils.hasText(nickname)) {`
`16`	`17`	`throw new IllegalArgumentException(NICKNAME_NOT_BLANK);`
`17`	`18`	`}`
`18`		`- if (nickname.length() > 20) {`
	`19`	`+ if (nickname.length() > User.MAX_NICKNAME_LENGTH) {`
`19`	`20`	`throw new IllegalArgumentException(NICKNAME_SIZE);`
`20`	`21`	`}`
`21`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`import static com.nexters.teamace.common.exception.ValidationErrorMessage.*;`
`4`	`4`
	`5`	`+import com.nexters.teamace.user.domain.User;`
`5`	`6`	`import org.springframework.util.StringUtils;`
`6`	`7`
`7`	`8`	`public record CreateUserCommand(String username, String nickname) {`
`@@ -10,15 +11,15 @@ public record CreateUserCommand(String username, String nickname) {`
`10`	`11`	`if (!StringUtils.hasText(username)) {`
`11`	`12`	`throw new IllegalArgumentException(USERNAME_NOT_BLANK);`
`12`	`13`	`}`
`13`		`- if (username.length() > 20) {`
	`14`	`+ if (username.length() > User.MAX_USERNAME_LENGTH) {`
`14`	`15`	`throw new IllegalArgumentException(USERNAME_SIZE);`
`15`	`16`	`}`
`16`	`17`	`}`
`17`	`18`	`if (nickname != null) {`
`18`	`19`	`if (!StringUtils.hasText(nickname)) {`
`19`	`20`	`throw new IllegalArgumentException(NICKNAME_NOT_BLANK);`
`20`	`21`	`}`
`21`		`- if (nickname.length() > 20) {`
	`22`	`+ if (nickname.length() > User.MAX_NICKNAME_LENGTH) {`
`22`	`23`	`throw new IllegalArgumentException(NICKNAME_SIZE);`
`23`	`24`	`}`
`24`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -50,17 +50,17 @@ void it_throws_IllegalArgumentException() {`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`@Nested`
`53`		`- @DisplayName("20자보다 긴 사용자명으로 생성할 때")`
	`53`	`+ @DisplayName("50자보다 긴 사용자명으로 생성할 때")`
`54`	`54`	`class Context_when_creating_with_username_longer_than_20_characters {`
`55`	`55`
`56`	`56`	`@Test`
`57`	`57`	`@DisplayName("IllegalArgumentException을 던진다")`
`58`	`58`	`void it_throws_IllegalArgumentException() {`
`59`		`- final String longUsername = "a".repeat(21);`
	`59`	`+ final String longUsername = "a".repeat(51);`
`60`	`60`
`61`	`61`	`thenThrownBy(() -> new LoginCommand(longUsername))`
`62`	`62`	`.isInstanceOf(IllegalArgumentException.class)`
`63`		`- .hasMessage("Username must be between 1 and 20 characters");`
	`63`	`+ .hasMessage("Username must be between 1 and 50 characters");`
`64`	`64`	`}`
`65`	`65`	`}`
`66`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -51,17 +51,17 @@ void it_throws_IllegalArgumentException() {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`@Nested`
`54`		`- @DisplayName("20자보다 긴 사용자명으로 생성할 때")`
	`54`	`+ @DisplayName("50자보다 긴 사용자명으로 생성할 때")`
`55`	`55`	`class Context_when_creating_with_username_longer_than_20_characters {`
`56`	`56`
`57`	`57`	`@Test`
`58`	`58`	`@DisplayName("IllegalArgumentException을 던진다")`
`59`	`59`	`void it_throws_IllegalArgumentException() {`
`60`		`- final String longUsername = "a".repeat(21);`
	`60`	`+ final String longUsername = "a".repeat(51);`
`61`	`61`
`62`	`62`	`thenThrownBy(() -> new SignupCommand(longUsername, "Valid User"))`
`63`	`63`	`.isInstanceOf(IllegalArgumentException.class)`
`64`		`- .hasMessage("Username must be between 1 and 20 characters");`
	`64`	`+ .hasMessage("Username must be between 1 and 50 characters");`
`65`	`65`	`}`
`66`	`66`	`}`
`67`	`67`
Original file line number	Diff line number	Diff line change
`@@ -66,17 +66,17 @@ void it_throws_IllegalArgumentException() {`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`@Nested`
`69`		`- @DisplayName("20자보다 긴 사용자명으로 생성할 때")`
	`69`	`+ @DisplayName("50자보다 긴 사용자명으로 생성할 때")`
`70`	`70`	`class Context_when_creating_with_username_longer_than_20_characters {`
`71`	`71`
`72`	`72`	`@Test`
`73`	`73`	`@DisplayName("IllegalArgumentException을 던진다")`
`74`	`74`	`void it_throws_IllegalArgumentException() {`
`75`		`- final String longUsername = "a".repeat(21);`
	`75`	`+ final String longUsername = "a".repeat(51);`
`76`	`76`
`77`	`77`	`thenThrownBy(() -> new CreateUserCommand(longUsername, "Valid User"))`
`78`	`78`	`.isInstanceOf(IllegalArgumentException.class)`
`79`		`- .hasMessage("Username must be between 1 and 20 characters");`
	`79`	`+ .hasMessage("Username must be between 1 and 50 characters");`
`80`	`80`	`}`
`81`	`81`	`}`
`82`	`82`