Skip to content

Commit bf8ec52

Browse files
committed
[#58] feat: emotion 도메인 클래스를 제거하고 이름 검증용 enum 클래스만 유지
1 parent 8e25550 commit bf8ec52

File tree

8 files changed

+25
-50
lines changed

8 files changed

+25
-50
lines changed

src/main/java/com/nexters/teamace/emotion/domain/Emotion.java

Lines changed: 0 additions & 25 deletions
This file was deleted.

src/main/java/com/nexters/teamace/emotion/domain/EmotionType.java renamed to src/main/java/com/nexters/teamace/emotion/domain/EmotionName.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
@Getter
99
@RequiredArgsConstructor
10-
public enum EmotionType {
10+
public enum EmotionName {
1111
ANGER("분노"),
1212
SADNESS("슬픔"),
1313
JEALOUSY("질투"),
@@ -20,11 +20,11 @@ public enum EmotionType {
2020
SOLITUDE("고독"),
2121
SHAME("부끄러움");
2222

23-
private final String description;
24-
private static final List<String> EMOTION_NAMES =
25-
Arrays.stream(values()).map(EmotionType::name).toList();
23+
private final String displayName;
24+
private static final List<String> NAMES =
25+
Arrays.stream(values()).map(EmotionName::name).toList();
2626

27-
public static List<String> getEmotionNames() {
28-
return EMOTION_NAMES;
27+
public static List<String> getNames() {
28+
return NAMES;
2929
}
3030
}

src/main/java/com/nexters/teamace/emotion/infrastructure/EmotionEntity.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.nexters.teamace.emotion.infrastructure;
22

33
import com.nexters.teamace.common.infrastructure.entity.BaseEntity;
4-
import com.nexters.teamace.emotion.domain.EmotionType;
4+
import com.nexters.teamace.emotion.domain.EmotionName;
55
import jakarta.persistence.*;
66
import lombok.AccessLevel;
77
import lombok.Builder;
@@ -16,12 +16,12 @@ public class EmotionEntity extends BaseEntity {
1616

1717
@Enumerated(EnumType.STRING)
1818
@Column(nullable = false, unique = true, length = 255)
19-
private EmotionType name;
19+
private EmotionName name;
2020

2121
private String description;
2222

2323
@Builder
24-
public EmotionEntity(long id, EmotionType name, String description) {
24+
public EmotionEntity(long id, EmotionName name, String description) {
2525
super(id);
2626
this.name = name;
2727
this.description = description;

src/main/java/com/nexters/teamace/fairy/application/FairyService.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import com.nexters.teamace.conversation.domain.ConversationContextType;
1212
import com.nexters.teamace.conversation.domain.ConversationType;
1313
import com.nexters.teamace.conversation.domain.EmotionSelectConversation;
14-
import com.nexters.teamace.emotion.domain.EmotionType;
14+
import com.nexters.teamace.emotion.domain.EmotionName;
1515
import com.nexters.teamace.fairy.application.dto.FairyInfo;
1616
import com.nexters.teamace.fairy.domain.Fairy;
1717
import com.nexters.teamace.fairy.domain.FairyBook;
@@ -20,7 +20,6 @@
2020
import com.nexters.teamace.fairy.infrastructure.AcquiredFairyEntity;
2121
import com.nexters.teamace.fairy.infrastructure.AcquiredFairyJpaRepository;
2222
import com.nexters.teamace.fairy.infrastructure.dto.FairyProjection;
23-
2423
import java.util.*;
2524
import java.util.stream.Collectors;
2625
import lombok.RequiredArgsConstructor;
@@ -37,7 +36,7 @@ public class FairyService {
3736
private final FairyRepository fairyRepository;
3837
private final AcquiredFairyJpaRepository acquiredFairyJpaRepository;
3938

40-
private static final String EMOTION_NAMES_STRING = EmotionType.getEmotionNames().toString();
39+
private static final String EMOTION_NAMES_STRING = EmotionName.getNames().toString();
4140

4241
@ReadOnlyTransactional
4342
public FairyResult getFairy(UserInfo user, Long chatRoomId) {
@@ -82,10 +81,11 @@ private EmotionSelectConversation analyzeEmotions(List<String> conversationHisto
8281

8382
private List<FairyProjection> findFairyCandidates(
8483
EmotionSelectConversation emotionSelectConversation) {
85-
var emotions = emotionSelectConversation.emotions().stream()
86-
.map(e -> EmotionType.valueOf(e.name()))
87-
.distinct()
88-
.toList();
84+
var emotions =
85+
emotionSelectConversation.emotions().stream()
86+
.map(e -> EmotionName.valueOf(e.name()))
87+
.distinct()
88+
.toList();
8989
if (emotions.isEmpty()) {
9090
return List.of();
9191
}
@@ -101,7 +101,7 @@ private List<FairyInfo> convertToFairyInfo(List<FairyProjection> fairyProjection
101101
p.name(),
102102
p.image(),
103103
p.silhouetteImage(),
104-
p.emotion().getDescription()))
104+
p.emotionName().getDisplayName()))
105105
.toList();
106106
}
107107

src/main/java/com/nexters/teamace/fairy/domain/FairyRepository.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.nexters.teamace.fairy.domain;
22

33
import com.nexters.teamace.common.exception.CustomException;
4-
import com.nexters.teamace.emotion.domain.EmotionType;
4+
import com.nexters.teamace.emotion.domain.EmotionName;
55
import com.nexters.teamace.fairy.infrastructure.dto.FairyProjection;
66
import java.util.List;
77
import java.util.Optional;
@@ -13,7 +13,7 @@ public interface FairyRepository {
1313

1414
List<Fairy> findAll();
1515

16-
List<FairyProjection> findAllByEmotionNames(List<EmotionType> emotionNames);
16+
List<FairyProjection> findAllByEmotionNames(List<EmotionName> emotionNames);
1717

1818
default Fairy getById(Long id) {
1919
return findById(id).orElseThrow(() -> CustomException.FAIRY_NOT_FOUND);

src/main/java/com/nexters/teamace/fairy/infrastructure/FairyJpaRepository.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.nexters.teamace.fairy.infrastructure;
22

3-
import com.nexters.teamace.emotion.domain.EmotionType;
3+
import com.nexters.teamace.emotion.domain.EmotionName;
44
import com.nexters.teamace.fairy.infrastructure.dto.FairyProjection;
55
import java.util.List;
66
import org.springframework.data.jpa.repository.JpaRepository;
@@ -14,5 +14,5 @@ public interface FairyJpaRepository extends JpaRepository<FairyEntity, Long> {
1414
+ "FROM FairyEntity f JOIN f.emotion e "
1515
+ "WHERE e.name IN :emotionNames")
1616
List<FairyProjection> findAllByEmotionNames(
17-
@Param("emotionNames") List<EmotionType> emotionNames);
17+
@Param("emotionNames") List<EmotionName> emotionNames);
1818
}

src/main/java/com/nexters/teamace/fairy/infrastructure/FairyRepositoryImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.nexters.teamace.fairy.infrastructure;
22

3-
import com.nexters.teamace.emotion.domain.EmotionType;
3+
import com.nexters.teamace.emotion.domain.EmotionName;
44
import com.nexters.teamace.emotion.infrastructure.EmotionEntity;
55
import com.nexters.teamace.emotion.infrastructure.EmotionJpaRepository;
66
import com.nexters.teamace.fairy.domain.Fairy;
@@ -41,7 +41,7 @@ public Optional<Fairy> findById(Long id) {
4141
}
4242

4343
@Override
44-
public List<FairyProjection> findAllByEmotionNames(List<EmotionType> emotionNames) {
44+
public List<FairyProjection> findAllByEmotionNames(List<EmotionName> emotionNames) {
4545
return fairyJpaRepository.findAllByEmotionNames(emotionNames);
4646
}
4747

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.nexters.teamace.fairy.infrastructure.dto;
22

3-
import com.nexters.teamace.emotion.domain.EmotionType;
3+
import com.nexters.teamace.emotion.domain.EmotionName;
44

55
public record FairyProjection(
6-
Long id, String name, String image, String silhouetteImage, EmotionType emotion) {}
6+
Long id, String name, String image, String silhouetteImage, EmotionName emotionName) {}

0 commit comments

Comments
 (0)