Fix phpstan issues

Author: paulbalandan

phpstan-baseline.php

@@ -13,6 +13,12 @@
 	'count' => 1,
 	'path' => __DIR__ . '/src/Nexus/Option/functions.php',
 ];
+$ignoreErrors[] = [
+	'rawMessage' => 'Parameter #3 ...$values of function sprintf expects bool|float|int|string|null, mixed given.',
+	'identifier' => 'argument.type',
+	'count' => 1,
+	'path' => __DIR__ . '/src/Nexus/Password/Hash/Pbkdf2Hash.php',
+];
 $ignoreErrors[] = [
 	'rawMessage' => 'Method Nexus\\Tests\\AutoReview\\ComposerJsonTest::getComposer() should return array<string, mixed> but returns mixed.',
 	'identifier' => 'return.type',

phpstan.dist.neon

@@ -21,11 +21,12 @@ parameters:
       - tools/vendor/**
   bootstrapFiles:
     - vendor/autoload.php
+  checkBenevolentUnionTypes: true
   checkMissingCallableSignature: true
   checkMissingOverrideMethodAttribute: true
+  checkStrictPrintfPlaceholderTypes: false
   checkTooWideReturnTypesInProtectedAndPublicMethods: true
   checkUninitializedProperties: true
-  checkBenevolentUnionTypes: true
   reportAlwaysTrueInLastCondition: true
   reportAnyTypeWideningInVarTag: true
   treatPhpDocTypesAsCertain: false

src/Nexus/Password/Hash/Pbkdf2Hash.php

@@ -19,11 +19,15 @@
 
 final readonly class Pbkdf2Hash extends AbstractHash implements SaltedHashInterface
 {
-    private const array ALLOWED_ALGORITHMS = [
+    /**
+     * @internal
+     */
+    public const array ALLOWED_ALGORITHMS = [
         Algorithm::Pbkdf2HmacSha1,
         Algorithm::Pbkdf2HmacSha256,
         Algorithm::Pbkdf2HmacSha512,
     ];
+
     private const int DEFAULT_LENGTH = 40;
     private const int MINIMUM_LENGTH = 0;
     private const int MINIMUM_ITERATIONS = 1_000;
@@ -39,6 +43,7 @@
     private int $length;
 
     /**
+     * @param value-of<self::ALLOWED_ALGORITHMS> $algorithm
      * @param array{
      *  iterations?: int,
      *  length?: int,
@@ -62,7 +67,6 @@ public function __construct(
         }
 
         $validatedOptions = self::validatedOptions($options, $this->defaultIterations(), self::DEFAULT_LENGTH);
-
         $this->iterations = $validatedOptions['iterations'];
         $this->length = $validatedOptions['length'];
     }
@@ -183,7 +187,7 @@ private function defaultIterations(): int
         return match ($this->algorithm) {
             Algorithm::Pbkdf2HmacSha1 => 1_300_000,
             Algorithm::Pbkdf2HmacSha256 => 600_000,
-            default => 210_000,
+            Algorithm::Pbkdf2HmacSha512 => 210_000,
         };
     }
 

tests/Password/Hash/Pbkdf2HashTest.php

@@ -36,7 +36,7 @@ public function testInvalidAlgorithm(): void
         $this->expectException(HashException::class);
         $this->expectExceptionMessage('Algorithm expected to be any of Algorith::Pbkdf2HmacSha1, Algorith::Pbkdf2HmacSha256, Algorith::Pbkdf2HmacSha512, but Algorithm::Argon2i given.');
 
-        new Pbkdf2Hash(Algorithm::Argon2i);
+        new Pbkdf2Hash(Algorithm::Argon2i); // @phpstan-ignore argument.type
     }
 
     public function testInvalidIterations(): void
@@ -55,6 +55,9 @@ public function testInvalidLength(): void
         new Pbkdf2Hash(Algorithm::Pbkdf2HmacSha512, ['length' => -1]);
     }
 
+    /**
+     * @param value-of<Pbkdf2Hash::ALLOWED_ALGORITHMS> $algorithm
+     */
     #[DataProvider('provideDefaultIterationsCases')]
     public function testDefaultIterations(Algorithm $algorithm, int $iterations): void
     {